Bug 1091648 - Bad error checking code in feature/gfid-access
Summary: Bad error checking code in feature/gfid-access
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: 3.5.0
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Ric Wheeler
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-26 23:55 UTC by Keith Schincke
Modified: 2014-06-19 14:52 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-19 14:52:49 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Keith Schincke 2014-04-26 23:55:05 UTC
Description of problem:
On line 99 gfid-access.c there is a check to see if the length of the blob is compaired to blob_len_len. This test is repeated on line 100. This resutls in a 


        len = strnlen (blob, blob_len);
        if (len == blob_len)
        if (len == blob_len) {
                gf_log (this->name, GF_LOG_ERROR,
                        "gfid: %s. No null byte present.",
                        args->gfid);
                goto err;
        }

Version-Release number of selected component (if applicable):
In at least 3.5 and glusterfs-20140408.5216e53

The code was merged here:
https://github.com/gluster/glusterfs/commit/3b8b184afe5579425e0e4dcb50dd8dd99d33b63a

How reproducible:
Always.

Steps to Reproduce:
1. Look at line 99 of xlators/features/gfid-access/src/gfid-access.c
2.
3.

Actual results:


Expected results:


Additional info:
Delete either line 99 or 100.

Comment 3 Keith Schincke 2014-06-19 14:52:23 UTC
This issue was fixed with the following unrelated commit

http://git.gluster.org/?p=glusterfs.git;a=commitdiff;h=99781d55f16373e793138c7b011eea09a62075b9


bz:
https://bugzilla.redhat.com/show_bug.cgi?id=1104919


Note You need to log in before you can comment on or make changes to this bug.