Bug 1100768 - Review Request: rubygem-fog-core - Shared classes and tests for fog providers and services.
Summary: Review Request: rubygem-fog-core - Shared classes and tests for fog providers...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josef Stribny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1100461
Blocks: 973071 1100776 1100795
TreeView+ depends on / blocked
 
Reported: 2014-05-23 12:14 UTC by Vít Ondruch
Modified: 2016-01-04 05:52 UTC (History)
4 users (show)

Fixed In Version: rubygem-fog-core-1.22.0-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-28 13:48:04 UTC
Type: ---
Embargoed:
jstribny: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Vít Ondruch 2014-05-23 12:14:07 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-fog-core.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-fog-core-1.22.0-1.fc21.src.rpm
Description: Shared classes and tests for fog providers and services.
Fedora Account System Username: vondruch

Comment 1 Josef Stribny 2014-05-23 12:49:28 UTC
* LICENSE.md, README.md and changelog.md files should be marked as %doc.
* There is some trailing white space in spec you probably want to remove.

Otherwise the package builds, installs, runs. Tests are passing. rpmlint doesn't complain. As the issues are minor and easy to fix => APPROVED. Please fix them before pushing.

Comment 2 Vít Ondruch 2014-05-23 13:12:38 UTC
Thanks for the review. I fixed the issues locally.



New Package SCM Request
=======================
Package Name: rubygem-fog-core
Short Description: Shared classes and tests for fog providers and services
Upstream URL: https://github.com/fog/fog-core
Owners: vondruch
Branches: 
InitialCC:

Comment 3 Gwyn Ciesla 2014-05-27 13:16:04 UTC
Git done (by process-git-requests).

Comment 4 Gwyn Ciesla 2014-05-27 13:23:30 UTC
Git done (by process-git-requests).

Comment 5 Troy Dawson 2014-12-18 23:33:43 UTC
Package Change Request
======================
Package Name: rubygem-fog-core
New Branches: epel7
Owners: tdawson

Comment 6 Gwyn Ciesla 2014-12-19 13:40:54 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.