Bug 1104919 - Fix memory leaks in gfid-access xlator.
Summary: Fix memory leaks in gfid-access xlator.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: unclassified
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vijay Bellur
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1104921
TreeView+ depends on / blocked
 
Reported: 2014-06-05 03:40 UTC by Raghavendra G
Modified: 2014-06-24 11:05 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.5.1beta2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1104921 (view as bug list)
Environment:
Last Closed: 2014-06-24 11:05:38 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Raghavendra G 2014-06-05 03:40:12 UTC
Description of problem:
A superficial glance while reviewing http://review.gluster.org/#/c/7978/ revealed two memory leaks. A more comprehensive code review is needed.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Pranith Kumar K 2014-06-05 03:43:35 UTC
I found more leaks/corruption upon further review. Will be using the same bug to send the fix.

Pranith

Comment 2 Anand Avati 2014-06-05 04:40:39 UTC
REVIEW: http://review.gluster.org/7982 (features/gfid-access: Fix memory leaks.) posted (#1) for review on master by Raghavendra G (rgowdapp)

Comment 3 Anand Avati 2014-06-05 05:02:15 UTC
REVIEW: http://review.gluster.org/7982 (features/gfid-access: Fix memory leaks.) posted (#2) for review on master by Raghavendra G (rgowdapp)

Comment 4 Anand Avati 2014-06-05 05:04:24 UTC
REVIEW: http://review.gluster.org/7983 (features/gfid-access: Fix memory leaks.) posted (#1) for review on release-3.5 by Raghavendra G (rgowdapp)

Comment 5 Anand Avati 2014-06-08 06:40:08 UTC
REVIEW: http://review.gluster.org/8009 (features/gfid-access: Fix inode leaks and loc path corruption) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 6 Anand Avati 2014-06-09 08:17:59 UTC
REVIEW: http://review.gluster.org/7982 (features/gfid-access: Fix memory leaks.) posted (#3) for review on master by Raghavendra G (rgowdapp)

Comment 7 Anand Avati 2014-06-09 08:19:10 UTC
REVIEW: http://review.gluster.org/7983 (features/gfid-access: Fix memory leaks.) posted (#2) for review on release-3.5 by Raghavendra G (rgowdapp)

Comment 8 Anand Avati 2014-06-09 08:25:13 UTC
REVIEW: http://review.gluster.org/7983 (features/gfid-access: Fix memory leaks.) posted (#3) for review on release-3.5 by Raghavendra G (rgowdapp)

Comment 9 Anand Avati 2014-06-09 08:27:36 UTC
REVIEW: http://review.gluster.org/7982 (features/gfid-access: Fix memory leaks.) posted (#4) for review on master by Raghavendra G (rgowdapp)

Comment 10 Anand Avati 2014-06-10 09:06:50 UTC
COMMIT: http://review.gluster.org/7982 committed in master by Vijay Bellur (vbellur) 
------
commit f6262b543f0eaa08c2d69310bf2353c9cba009e6
Author: Raghavendra G <rgowdapp>
Date:   Thu Jun 5 10:06:47 2014 +0530

    features/gfid-access: Fix memory leaks.
    
    Change-Id: I90f6cdb1c8c4face1bb72a9cc77818d308389e45
    BUG: 1104919
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/7982
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 11 Anand Avati 2014-06-10 09:37:57 UTC
COMMIT: http://review.gluster.org/7983 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit b167a0ca7f418abd0ff08cf0332593b00e27caee
Author: Raghavendra G <rgowdapp>
Date:   Thu Jun 5 10:06:47 2014 +0530

    features/gfid-access: Fix memory leaks.
    
    Change-Id: I90f6cdb1c8c4face1bb72a9cc77818d308389e45
    BUG: 1104919
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/7983
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 12 Anand Avati 2014-06-10 15:01:26 UTC
COMMIT: http://review.gluster.org/8009 committed in master by Vijay Bellur (vbellur) 
------
commit 99781d55f16373e793138c7b011eea09a62075b9
Author: Pranith Kumar K <pkarampu>
Date:   Sun Jun 8 11:23:26 2014 +0530

    features/gfid-access: Fix inode leaks and loc path corruption
    
    Change-Id: Ib506db28415d57b344aa90e07e74666ad2063c64
    BUG: 1104919
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8009
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kotresh HR <khiremat>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 13 Anand Avati 2014-06-10 16:08:33 UTC
REVIEW: http://review.gluster.org/8028 (features/gfid-access: Fix inode leaks and loc path corruption) posted (#1) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)

Comment 14 Niels de Vos 2014-06-10 16:52:08 UTC
The second (and last?) Beta for GlusterFS 3.5.1 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.1beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040547.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 15 Niels de Vos 2014-06-24 11:05:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.1, please reopen this bug report.

glusterfs-3.5.1 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040723.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.