Bug 1105312 - Traceback on bad input during staypuft-installer network configuration
Summary: Traceback on bad input during staypuft-installer network configuration
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: rhel-osp-installer
Version: 5.0 (RHEL 7)
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ga
: 5.0 (RHEL 6)
Assignee: Marek Hulan
QA Contact: Omri Hochman
URL:
Whiteboard:
: 1110302 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-05 20:38 UTC by James Slagle
Modified: 2014-09-08 05:20 UTC (History)
7 users (show)

Fixed In Version: rhel-osp-installer-0.0.25-2.el6ost
Doc Type: Bug Fix
Doc Text:
internal only, no doc text needed
Clone Of:
Environment:
Last Closed: 2014-08-04 18:33:59 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2014:1003 0 normal SHIPPED_LIVE Red Hat Enterprise Linux OpenStack Platform Enhancement Advisory 2014-08-04 22:31:07 UTC

Description James Slagle 2014-06-05 20:38:49 UTC
Description of problem:

Got a traceback when I didn't enter values for the networking configuration while running staypuft-installer.

Version-Release number of selected component (if applicable):
[root@staypuft ~]# rpm -q foreman-installer-staypuft
foreman-installer-staypuft-0.0.14-1.el6ost.noarch


How reproducible:
always

Steps to Reproduce:
1. run staypuft-installer
2. choose an interface
3. leave networking configuration blank
4. get a traceback

Actual results:
    [root@staypuft ~]# staypuft-installer
    Provisioning setup
     
    Please select NIC on which you want Foreman provisioning enabled:
    1. eth1
    2. eth0
    ?  1
     
    Current networking setup:
           Network interface: 'eth1'
                  IP address: ''
                Network mask: ''
             Network address: ''
            DHCP range start: ''
              DHCP range end: ''
                     Gateway: '192.168.122.1'
               DNS forwarder: '192.168.122.1'
                      Domain: 'localdomain'
                 Foreman URL: 'https://staypuft.localdomain'
    Set this host networking: ✓
     
    Is the networking correct?:
    1. Yes, move on!
    2. No, change Network interface
    3. No, change IP address
    4. No, change Network mask
    5. No, change Network address
    6. No, change DHCP range start
    7. No, change DHCP range end
    8. No, change Gateway
    9. No, change DNS forwarder
    10. No, change Domain
    11. No, change Foreman URL
    12. No, change Set this host networking
    13. No, cancel installation
    1
    /usr/share/foreman-installer/hooks/pre_validations/10-gather_and_set_staypuft_values.rb:13:in `load': private method `split' called for nil:NilClass (NoMethodError)
            from /usr/lib/ruby/gems/1.8/gems/kafo-0.6.0/lib/kafo/hook_context.rb:13:in `instance_exec'
            from /usr/lib/ruby/gems/1.8/gems/kafo-0.6.0/lib/kafo/hook_context.rb:13:in `execute'
            from /usr/lib/ruby/gems/1.8/gems/kafo-0.6.0/lib/kafo/hooking.rb:48:in `execute'
            from /usr/lib/ruby/gems/1.8/gems/kafo-0.6.0/lib/kafo/hooking.rb:47:in `each_pair'
            from /usr/lib/ruby/gems/1.8/gems/kafo-0.6.0/lib/kafo/hooking.rb:47:in `execute'
            from /usr/lib/ruby/gems/1.8/gems/kafo-0.6.0/lib/kafo/kafo_configure.rb:92:in `execute'
            from /usr/lib/ruby/gems/1.8/gems/clamp-0.6.2/lib/clamp/command.rb:67:in `run'
            from /usr/lib/ruby/gems/1.8/gems/clamp-0.6.2/lib/clamp/command.rb:125:in `run'
            from /usr/lib/ruby/gems/1.8/gems/kafo-0.6.0/lib/kafo/kafo_configure.rb:116:in `run'
            from /usr/sbin/staypuft-installer:54


Expected results:
Error message telling me I didn't fill in some required fields. Or some indication the fields are required.

Additional info:
I honestly thought this was asking me to confirm the *existing* configuration, which was exactly right as shown. eth1 current was assigned no IP, etc.

Comment 2 Mike Burns 2014-06-17 18:17:46 UTC
We should validate the user input

Comment 3 Mike Burns 2014-06-17 18:17:49 UTC
*** Bug 1110302 has been marked as a duplicate of this bug. ***

Comment 4 Marek Hulan 2014-06-24 14:52:10 UTC
Fixed in 0.0.23

Comment 6 Alexander Chuzhoy 2014-07-03 18:28:05 UTC
Verified: rhel-osp-installer-0.1.0-2.el6ost.noarch

The error doesn't reproduce now.

Note:
1. The menu is different now.
2. The installation is invoked by runing: rhel-osp-installer.

Comment 9 errata-xmlrpc 2014-08-04 18:33:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-1003.html


Note You need to log in before you can comment on or make changes to this bug.