Bug 110673 - Bad none .pls .m3u handling when saving playlists
Summary: Bad none .pls .m3u handling when saving playlists
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xmms
Version: 1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-11-22 23:11 UTC by Philip Wyett
Modified: 2014-03-17 02:40 UTC (History)
2 users (show)

Fixed In Version: 1.2.9-1.p
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-01-29 04:35:56 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to fix 'Unable to save playlist problem' (478 bytes, patch)
2003-11-23 02:48 UTC, Philip Wyett
no flags Details | Diff

Description Philip Wyett 2003-11-22 23:11:38 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1)
Gecko/20031114

Description of problem:
When attempting to save a playlist and forget to select '.pls', '.m3u'
and leave 'Determine file type' as 'By extension' and not add a '.pls'
or '.m3u' extension xmms will just sit there and not save the file or
prompt you that their is a problem. If you look in the gnome panel it
tells you 'Unable to save playlist', but not on screen and the
playlist save dialog stops responding to mouse clicks until you goto
the gnome panel, right click and click close on 'Unable to save playlist'.

Version-Release number of selected component (if applicable):
xmms-1.2.8-3.p

How reproducible:
Always

Steps to Reproduce:
1. Start xmms and load up some songs
2. Right click in playlist window and then select 'Playlist -> Save list'
3. Leave on 'Determine file type' and enter filename 'my_playlist' and
click on 'Ok'
    

Actual Results:  A 'Unable to save playlist' is given in the gnome
panel, but not on screen and the playlist save dialog becomes
unresponsive to any mouse clicks until you right click on the 'Unable
to save playlist' and close it.

Expected Results:  I should be given the error dialog on
screen/desktop stating that the playlist could not be saved.

Additional info:

Comment 1 Philip Wyett 2003-11-23 02:47:24 UTC
Oops my fault here. The actual problem is the 'Unable to save
playlist' dilaog is getting trapped behind the 'Save playlist' window
when the desktop is full. This is due to a bad call to
'gtk_window_set_transient_for()', where the args are the wrong way
round. A patch to fix the problem and set the parent and child windows
correctly and have the 'Unable to save playlist' dialog appear on top
is attached.

Comment 2 Philip Wyett 2003-11-23 02:48:27 UTC
Created attachment 96140 [details]
Patch to fix 'Unable to save playlist problem'

Comment 3 Bill Nottingham 2003-11-24 04:14:46 UTC
Havard: does the patch look ok to you?

Comment 4 Håvard Kvålen 2003-11-24 23:44:06 UTC
Yes, it has been applied to our cvs tree.

Comment 5 Bill Nottingham 2004-01-29 04:35:56 UTC
This should be fixed in 1.2.9-1.p.


Note You need to log in before you can comment on or make changes to this bug.