Red Hat Bugzilla – Bug 110697
bad source code
Last modified: 2013-07-02 18:58:58 EDT
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)
Description of problem:
I just tried to compile package compat-db-4_0_14-2 with compiler
The compiler said
../db_load/db_load.c:810: warning: operation on `instr' may be
The source code file is
The source code is
c = digitize(dbenv, *instr, &e1) << 4 |
digitize(dbenv, *++instr, &e2);
Much better code is
c = digitize(dbenv, instr[ 0], &e1) << 4 |
digitize(dbenv, instr[ 1], &e2);
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. compile package with compiler flag -Wall.
Created attachment 114057 [details]
Patch that clarifies the correct behavior
The pointer arithmetics is now clarified since compat-db-4.2.52-4.
From User-Agent: XML-RPC
compat-db-4.2.52-2.FC4 has been pushed for FC4, which should resolve this issue. If these problems are still present in this version, then please make note of it in this bug report.