From Bugzilla Helper: User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98) Description of problem: I just tried to compile package elinks-0_4_2-7_1 from Fedora. The compiler said charsets.c(147): warning #187: use of "=" where "==" may have been intended The source code is BIN_SEARCH(unicode_7b, x, N_UNICODE_7B, u, s); The definition of macro BIN_SEARCH is #define BIN_SEARCH(table, entry, entries, key, result) \ { \ long _s = 0, _e = (entries) - 1; \ while (_s <= _e || !((result) = -1)) { Suspect this last line I have shown would be better as while (_s <= _e || !((result) == -1)) { Version-Release number of selected component (if applicable): elinks-0_4_2-7_1 How reproducible: Always Steps to Reproduce: 1. by source code inspection 2. 3. Additional info:
No, this code looks right. You are paying too much attention to the compiler warnings and not enough to the intention of the author of the code. :-)