Bug 110750 - obsolete source code
Summary: obsolete source code
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: FreeWnn
Version: 1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Bill Huang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-11-24 13:55 UTC by d.binderman
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-08-06 02:19:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description d.binderman 2003-11-24 13:55:10 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)

Description of problem:
Hello there,

I've just been having a look at package FreeWnn-1_11-38 from Fedora.
I found

[root@ruth SPECS]# grep searchdesc ../BUILD/FreeWnn-1.1.1 
a017/Xsi/PubdicPlus/pod.c
searchdesc (hin, tan, yom)
      dp = searchdesc (dhinshi);

This means that routine searchdesc is defined with three parameters,
but only gets called with one. This is a problem for any
use of parameters tan & yom in the searchdesc routine.

Suggest remove parameters tan & yom. The source code is

static struct descpack *
searchdesc (hin, tan, yom)
     Wchar *hin, **tan, **yom;
{

Suggest also use ISO function prototypes. K&R code has been deprecated
for about fifteen years now.

static struct descpack *
searchdesc ( Wchar * hin)
{




Version-Release number of selected component (if applicable):
FreeWnn-1_11-38 

How reproducible:
Always

Steps to Reproduce:
1. by source code inspection
2.
3.
    

Additional info:

Comment 1 Jens Petersen 2004-03-23 03:28:52 UTC
Fixing in next update.

Comment 2 Jens Petersen 2004-08-06 02:19:39 UTC
This is fixed in upstream pl20.


Note You need to log in before you can comment on or make changes to this bug.