Bug 110779 - bad source code
Summary: bad source code
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libtiff   
(Show other bugs)
Version: 1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-11-24 15:45 UTC by d.binderman
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2004-05-19 19:47:30 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description d.binderman 2003-11-24 15:45:41 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)

Description of problem:


I just tried to compile package libtiff-3_5_7-14 from Fedora.

The compiler said

1.

../tools/tiffset.c:89: warning: too few arguments for format

The source code is

                fprintf( stderr, "Field name %s not recognised.\n" );

Looks like a missing field name for the %s specifier.

2.

../tools/tiffset.c:115: warning: too few arguments for format

Same problem as #1.

3.

../tools/tiffcp.c(98): remark #174: expression has no effect

The source code is

        if ((*imageSpec)[1] == '\0') *imageSpec == NULL;

Better source code might be

        if ((*imageSpec)[1] == '\0') *imageSpec = NULL;



Version-Release number of selected component (if applicable):
libtiff-3_5_7-14 

How reproducible:
Always

Steps to Reproduce:
1. by inspection
2.
3.
    

Additional info:


Note You need to log in before you can comment on or make changes to this bug.