Bug 110792 - bad source code
Summary: bad source code
Alias: None
Product: Fedora
Classification: Fedora
Component: ipchains
Version: 1
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Mike A. Harris
QA Contact: Ben Levenson
Keywords: EasyFix, Triaged
Depends On:
TreeView+ depends on / blocked
Reported: 2003-11-24 16:07 UTC by d.binderman
Modified: 2007-11-30 22:10 UTC (History)
0 users

Clone Of:
Last Closed: 2004-02-17 09:04:56 UTC

Attachments (Terms of Use)

Description d.binderman 2003-11-24 16:07:24 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)

Description of problem:

I just tried to compile package ipchains-1_3_10-19 from Fedora.

The compiler said


ipchains.c:2193: warning: `+' flag used with `%x' printf format
ipchains.c:2193: warning: `+' flag used with `%x' printf format

The source code is

                        fprintf(fp, FMT("0x%+-10x ","mark 0x%+x "),

The + flag is used for signed quantities, the %x flag is used for
unsigned quantities. You can have one or the other, not both. Pick 

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. by inspection

Additional info:

Comment 1 Mike A. Harris 2003-12-15 13:22:05 UTC
These types of rather IMHO harmless warnings, should be reported
directly to the upstream maintainer of the given software, so that
it gets fixed upstream and not just in one distribution.

Low priority issues like this also get a higher priority when
accompanied by a patch that fixes the issue.  ;o)

Comment 2 Mike A. Harris 2004-02-17 09:04:56 UTC
Fedora Core 2 will have a 2.6.x kernel, and we have dropped ipchains
support in our Fedora Core kernel because it isn't widely used or
tested nowadays.  We no longer support ipchains in future OS releases,
so I'm closing all ipchains bug reports that are open which are not
security related or mission critical.

Closing as 'WONTFIX'

Note You need to log in before you can comment on or make changes to this bug.