From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031114 Epiphany/1.0.4 Description of problem: User should be able to set/edit share name. Currently the last part of the share path is take as share name. Should also take care if two share paths have the same last part (/var/shares and /opt/shares). Version-Release number of selected component (if applicable): 1.1.4 How reproducible: Always Steps to Reproduce: 1. create a share. 2. 3. Actual Results: no share name is asked, or can be edited. Expected Results: Should let user edit share name. Additional info:
*** Bug 110815 has been marked as a duplicate of this bug. ***
Can you provide more information about why it is necessary to expose this in the user interface?
Because this is the name that is seen from a remote machine, so a users typically want to set it. Even if you cannot set it, at least it should somehow handle the case when you want to share both /home/user1/music and /home/user2/music. Then when you want to handle this, the cleanest way I can think of is to select something like music-1 music-2, ... and let user adjust it.
Since I need this myself, I am planning to implement this, any objections?
Philip: sure, go ahead.
Created attachment 100521 [details] Patch that implements this Have fun :-) [freax@pluisje redhat-config-samba]$ cd src/ [freax@pluisje src]$ cvs diff -u > /home/freax/system-config-samba-bug-110804-proposal-by-PhilipVanHoof.diff cvs server: Diffing . [freax@pluisje src]$
Created attachment 100640 [details] Patch that implements this feature request This fixes a tiny bug in my previous patch. Not it seems to be fully working [freax@pluisje redhat-config-samba]$ cvs diff -u > /home/freax/system-config-samba-bug-110804-proposal-by-PhilipVanHoof-take-2-05_27_2004_-_22h34m.diff cvs server: Diffing . cvs server: Diffing doc cvs server: Diffing doc/figs cvs server: Diffing pixmaps cvs server: Diffing po cvs server: Diffing src [freax@pluisje redhat-config-samba]$
Note to both: if you have questions about this implementation, feel free to contact me
Created attachment 100702 [details] Patch that implements this feature request with some extra's which are related This also changes some other behaviour like generating the sharename on text-changed in the dir-entry and adds a column in the treeview
Created attachment 100704 [details] Minor change since last patch This will also make sure that if you are in edit-mode, and the sharename already exist .. that it will be made unique by adding "-#" at the end of the textbox-value
For people who want to use this asap, I have setup a viewcvs that can create a tarball of the latest version: http://cvs.freax.be/cgi-bin/viewcvs.cgi/system-config-samba/system-config-samba.tar.gz?tarball=1
Package ownership changed.
Applied the patch to CVS and brought it a bit more into shape ;-).