Bug 1115633 - "Product Content" page shows edit buttons for read only user
Summary: "Product Content" page shows edit buttons for read only user
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Content Management
Version: 6.0.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Walden Raines
QA Contact: sthirugn@redhat.com
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On: 1124607
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-07-02 19:31 UTC by Walden Raines
Modified: 2019-09-26 18:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-11 12:27:16 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Content Host - Product Content tab not loading (51.21 KB, image/png)
2014-07-29 21:15 UTC, sthirugn@redhat.com
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 6479 0 None None None 2016-04-22 16:45:53 UTC

Description Walden Raines 2014-07-02 19:31:11 UTC
h3. Steps to Reproduce

1. Create a non-admin user
2. Give them the "view_content_hosts" permission
3. Go to systems -> choose a system -> product content
4. Notice you can see edit buttons
5. Attempt to save
6. Notice 403

Comment 1 Walden Raines 2014-07-02 19:31:13 UTC
Created from redmine issue http://projects.theforeman.org/issues/6479

Comment 2 Walden Raines 2014-07-02 19:31:17 UTC
Upstream bug assigned to walden

Comment 4 Walden Raines 2014-07-02 19:59:12 UTC
PR: https://github.com/Katello/katello/pull/4383

Comment 5 Walden Raines 2014-07-07 14:45:52 UTC
commit f2079e13b8b2ae3aa4fba89d1bec62b758bcb9a0
Merge: 5bbadc3 22032b7
Author: Walden Raines <walden>
Date:   Mon Jul 7 10:44:58 2014 -0400

    Merge pull request #4383 from waldenraines/6479
    
    Fixes #6479/BZ1115633: hide product content edit button if applicable

commit ea15661e2af6b05ebaa86da38d3e18a8c24485f5
Author: Walden Raines <walden>
Date:   Fri Jun 27 08:23:58 2014 -0400

    Fixes #6078, #6300, BZ1105175, BZ1097054: fix invalid limit fields.
    
    This commit changes the way we handle limited fields such as Content Host
    number of systems and Activation Key usage limit.  Instead of representing
    "unlimited" as -1 we now represent it as a boolean on the object.
    
    http://projects.theforeman.org/issues/6078
    http://projects.theforeman.org/issues/6300
    https://bugzilla.redhat.com/show_bug.cgi?id=1105175
    https://bugzilla.redhat.com/show_bug.cgi?id=1097054

Comment 6 Walden Raines 2014-07-07 14:47:54 UTC
DISREGARD THE PREVIOUS COMMENT, IT HAS THE WRONG COMMITS.

Here are the correct commits:

commit f2079e13b8b2ae3aa4fba89d1bec62b758bcb9a0
Merge: 5bbadc3 22032b7
Author: Walden Raines <walden>
Date:   Mon Jul 7 10:44:58 2014 -0400

    Merge pull request #4383 from waldenraines/6479
    
    Fixes #6479/BZ1115633: hide product content edit button if applicable

commit 22032b7d2fdc23d21f31f4aceaa0522b3fa85e57
Author: Walden Raines <walden>
Date:   Wed Jul 2 15:55:57 2014 -0400

    Fixes #6479/BZ1115633: hide product content edit button if applicable
    
    If the user does not have permission do not show the product content
    edit button.
    
    http://projects.theforeman.org/issues/6479
    https://bugzilla.redhat.com/show_bug.cgi?id=1115633

Comment 8 sthirugn@redhat.com 2014-07-29 21:15:02 UTC
Failed.

Steps:
1. Create a non-admin user
2. Give them the "view_content_hosts" permission
3. Go to Hosts -> Content Hosts -> choose a Content Host -> product content
4. The page kept on loading...(see screenshot)

Version Tested:
Satellite-6.0.4-RHEL-6-20140723.0

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.19-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.19-1.el6_5.noarch
* candlepin-tomcat6-0.9.19-1.el6_5.noarch
* elasticsearch-0.90.10-4.el6sat.noarch
* foreman-1.6.0.29-1.el6sat.noarch
* foreman-compute-1.6.0.29-1.el6sat.noarch
* foreman-gce-1.6.0.29-1.el6sat.noarch
* foreman-libvirt-1.6.0.29-1.el6sat.noarch
* foreman-ovirt-1.6.0.29-1.el6sat.noarch
* foreman-postgresql-1.6.0.29-1.el6sat.noarch
* foreman-proxy-1.6.0.21-1.el6sat.noarch
* foreman-selinux-1.6.0-8.el6sat.noarch
* foreman-vmware-1.6.0.29-1.el6sat.noarch
* katello-1.5.0-27.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.56-1.el6sat.noarch
* openldap-2.4.23-32.el6_4.1.x86_64
* pulp-katello-0.3-3.el6sat.noarch
* pulp-nodes-common-2.4.0-0.23.beta.el6sat.noarch
* pulp-nodes-parent-2.4.0-0.23.beta.el6sat.noarch
* pulp-puppet-plugins-2.4.0-0.23.beta.el6sat.noarch
* pulp-puppet-tools-2.4.0-0.23.beta.el6sat.noarch
* pulp-rpm-plugins-2.4.0-0.23.beta.el6sat.noarch
* pulp-selinux-2.4.0-0.23.beta.el6sat.noarch
* pulp-server-2.4.0-0.23.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch

Comment 9 sthirugn@redhat.com 2014-07-29 21:15:28 UTC
Created attachment 922353 [details]
Content Host - Product Content tab not loading

Comment 10 Walden Raines 2014-07-29 22:04:59 UTC
(In reply to sthirugn from comment #8)
> Failed.
> 
> Steps:
> 1. Create a non-admin user
> 2. Give them the "view_content_hosts" permission
> 3. Go to Hosts -> Content Hosts -> choose a Content Host -> product content
> 4. The page kept on loading...(see screenshot)

I filed #1124607 for this as it's a separate bug than what is described above.

Comment 11 Walden Raines 2014-07-29 22:05:15 UTC
Bug #1124607

Comment 12 sthirugn@redhat.com 2014-08-07 16:10:31 UTC
This is blocked until 1124607 is fixed.

Comment 13 sthirugn@redhat.com 2014-08-10 14:07:19 UTC
ON_QA status means that the bug is ready to test for QA.  But this is blocked with an other issue.  Demoting to Assigned. Please move this to ON_QA when the other bug is fixed.

Comment 14 Walden Raines 2014-08-11 12:48:56 UTC
Bug #1124607 is also ON_QA though.

Comment 15 sthirugn@redhat.com 2014-08-11 14:53:03 UTC
Verified. The product content tab is now hidden for a user with permission - view_content_hosts.

Version Tested:
GA Snap 4 - Satellite-6.0.4-RHEL-6-20140806.0

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.19-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.19-1.el6_5.noarch
* candlepin-tomcat6-0.9.19-1.el6_5.noarch
* elasticsearch-0.90.10-4.el6sat.noarch
* foreman-1.6.0.38-1.el6sat.noarch
* foreman-compute-1.6.0.38-1.el6sat.noarch
* foreman-gce-1.6.0.38-1.el6sat.noarch
* foreman-libvirt-1.6.0.38-1.el6sat.noarch
* foreman-ovirt-1.6.0.38-1.el6sat.noarch
* foreman-postgresql-1.6.0.38-1.el6sat.noarch
* foreman-proxy-1.6.0.23-1.el6sat.noarch
* foreman-selinux-1.6.0.4-1.el6sat.noarch
* foreman-vmware-1.6.0.38-1.el6sat.noarch
* katello-1.5.0-28.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.57-1.el6sat.noarch
* openldap-2.4.23-34.el6_5.1.x86_64
* pulp-katello-0.3-3.el6sat.noarch
* pulp-nodes-common-2.4.0-0.30.beta.el6sat.noarch
* pulp-nodes-parent-2.4.0-0.30.beta.el6sat.noarch
* pulp-puppet-plugins-2.4.0-0.30.beta.el6sat.noarch
* pulp-puppet-tools-2.4.0-0.30.beta.el6sat.noarch
* pulp-rpm-plugins-2.4.0-0.30.beta.el6sat.noarch
* pulp-selinux-2.4.0-0.30.beta.el6sat.noarch
* pulp-server-2.4.0-0.30.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch
* sssd-ldap-1.11.5.1-3.el6.x86_64

Comment 16 Bryan Kearney 2014-09-11 12:27:16 UTC
This was delivered with Satellite 6.0 which was released on 10 September 2014.


Note You need to log in before you can comment on or make changes to this bug.