Bug 1117302 – [RFE] Collect data for VMs "vm_disk_actual_size_mb" including snapshots and change currect column name

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1117302 - [RFE] Collect data for VMs "vm_disk_actual_size_mb" including snapshots and change currect column name

Summary:	[RFE] Collect data for VMs "vm_disk_actual_size_mb" including snapshots and c...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-engine-dwh (Show other bugs)
Sub Component:
Version:	unspecified
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	ovirt-3.6.0-rc
Target Release:	3.6.0
Assigned To:	Shirly Radco
QA Contact:	Petr Matyáš
Docs Contact:

URL:
Whiteboard:
Keywords:	FutureFeature

Depends On:
Blocks:	1169105
	Show dependency tree / graph

Reported:	2014-07-08 09:13 EDT by Shirly Radco
Modified:	2016-03-09 16:21 EST (History)
CC List:	8 users (show)

See Also:
Fixed In Version:	OVIRT 3.6.0-1 first release
Doc Type:	Release Note
Doc Text:	Previously, the field "vm_disk_actual_size_mb", in "dwh_vm_disks_history_view", was the virtual machine disk size for the current snapshot of the virtual machine. It was decided that this information is irrelevant for collecting to the ovirt-engine-history database and what should be collected is the total disk size that the virtual machine is using, including all snapshots. From Red Hat Enterprise Virtualization 3.6 this field will show the Total virtual machine disk size. Previous collected data will be kept even though it is inaccurate.
Story Points:	---
Clone Of:
Clones:	1169105 (view as bug list)
Environment:
Last Closed:	2016-03-09 16:21:45 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Infra
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	sherold: Triaged+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	37798	None	None	None	Never
Red Hat Product Errata	RHEA-2016:0404	normal	SHIPPED_LIVE	rhevm-dwh bug fix and enhancement update	2016-03-09 20:29:45 EST

Groups: None (edit)

Description Shirly Radco 2014-07-08 09:13:41 EDT

Description of problem:

Correctly we collect only active stat statistics for vm devices from the dwh_vm_disks_history_view of the engine db.

This view filters data regarding snapshots and templates.

This data , for example "vm_disk_actual_size_mb" , is important if we want to know the total actual used disk size for the vm for that time.

Comment 5 Shirly Radco 2015-01-13 09:28:20 EST

I think that the data we collected in "vm_disk_actual_size_mb" is not really relevant and we should update it to include snapshots and not add another column.

It is only one snapshot out of maybe several. If we dont have snapshots for the vm then this number will correct but if we do then keeping only the size of the current snapshot is meaningless.
Do you agree?

Comment 6 Yaniv Lavi 2015-01-18 07:26:26 EST

(In reply to Shirly Radco from comment #5)
> I think that the data we collected in "vm_disk_actual_size_mb" is not really
> relevant and we should update it to include snapshots and not add another
> column.
> 
> It is only one snapshot out of maybe several. If we dont have snapshots for
> the vm then this number will correct but if we do then keeping only the size
> of the current snapshot is meaningless.
> Do you agree?

I agree. change the value from now on and resync the data, if it's not in a history table.

Comment 7 Petr Matyáš 2015-04-30 07:09:18 EDT

Could you please provide Fixed in version/Build ID?
Also, for verification is enough to check engine db dwh_vm_disks_history_view before and after snapshot creation if there is a difference in vm_disk_actual_size_mb?

Comment 8 Shirly Radco 2015-04-30 08:09:05 EDT

In order to test you will need an env with vms that have snapshots and see that the calculated value of the field is the sum of all snapshots and not only the size of the "Current" snapshot.

Comment 10 errata-xmlrpc 2016-03-09 16:21:45 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-0404.html

Note You need to log in before you can comment on or make changes to this bug.