Description of problem: It is currently possible to specify username "user" as a read only user during "rhevm-dwh-setup" step. It may also be accepted in other places. This results in an incorrect SQL query which results in a failed install. Version-Release number of selected component (if applicable): 3.3.2 How reproducible: Always Steps to Reproduce: 1. install rhev and reports-setup 2. start rhevm-dwh-setup 3. use "user" in this step: This utility can configure a read only user for DB access. Would you like to do so? (yes|no): yes Provide a username for read-only user: user Actual results: username is accepted, setup fails Expected results: username is rejected Additional info: resulting SQL query which fails: engine=# CREATE ROLE user with login encrypted password 'test'; ERROR: syntax error at or near "user" LINE 1: CREATE ROLE user with login encrypted password 'test'; ^ sample of different username which works: engine=# CREATE ROLE user123123 with login encrypted password 'test'; CREATE ROLE Other SQL words which may also need blacklisting (I tested "with" and it also fails)
Barak, should this be fixed for 3.3.z? IIRC we removed the option of adding the read-only user for 3.4 and above.
No we do not release 3.3.z any more, This issue is minor (and obselete in 3.4). And should have an easy workaround in the form of KB.
(In reply to Barak from comment #3) > No we do not release 3.3.z any more, > This issue is minor (and obselete in 3.4). > > And should have an easy workaround in the form of KB. Agreed. Closing.