Created attachment 927991 [details] red border doesn't appears on updating content-host limit with invalid value Description of problem: Found a failure in automation where we are updating the content-host-limit of an existing activation-key with some invalid value (say with some string), and UI doesn't highlight the input box with red border and save button remains disabled. Please note that this happens only while editing the activation-key. When we use invalid limit while creating activation-key, the red border appears. So the behaviour should be consistent with create activation-key. Version-Release number of selected component (if applicable): sat6 GA snap5 How reproducible: always Steps to Reproduce: 1. create a activation-key with default content-host-limit 2. update the limit with either string or -ve value 3. Actual results: UI doesn't highlight the input box with red border, when we update content-host-limit with some invalid value. Expected results: UI should highlight the input box with red border while updating the limit with some invalid value Additional info:
Created redmine issue http://projects.theforeman.org/issues/7142 from this bug
Upstream bug component is WebUI
Upstream bug component is Activation Keys
(In reply to Sachin Ghai from comment #0) > Expected results: > UI should highlight the input box with red border while updating the limit > with some invalid value We currently don't do this anywhere else in the application. Are we sure this is the expected behavior in this case? If so, we need to make this change everywhere in the application.
Currently, when we create an activation-key or a hostgroup with invalid value of content-host limit then UI raises error as highlighted box with red border. However, when we update the activation-key with invalid limit then UI doesn't raise any error instead make 'save' button inactive. I believe behaviour should be consistent both while creating and updating the entity limit. Is there any specific reason for making it different while updating ?
(In reply to Sachin Ghai from comment #6) > I believe behaviour should be consistent both while creating and updating > the entity limit. Is there any specific reason for making it different while > updating ? So currently it is consistent with editing other entities, it's just not consistent with creating entities. We can add a red border when editing activation key limits but we also need to do the same for other entities (host collections, etc). I'm fine with doing this, just note that other entities need to be tested as well.
Upstream bug component is Uncategorized
Upstream bug assigned to walden
This is an older bug, which is being tracked upstream. We will not be tracking this downstream. When the upstream issue is resolved, the next rebase will pull in the fix.