Bug 1132441 - FirewallD exposes a Python specific D-Bus exception type
Summary: FirewallD exposes a Python specific D-Bus exception type
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: firewalld
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Thomas Woerner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-21 11:26 UTC by Daniel Kopeček
Modified: 2014-11-01 16:25 UTC (History)
2 users (show)

Fixed In Version: firewalld-0.3.12-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-01 01:41:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Daniel Kopeček 2014-08-21 11:26:20 UTC
Description of problem:
When FirewallD returns a D-Bus error, it does so using a Python specific D-Bus type.

Actual results:
 org.freedesktop.DBus.Python.dbus.exceptions.DBusException: INVALID_ZONE: lksflkds

Expected results:

 org.freedesktop.FirewallD.Error: INVALID_ZONE: lksflkds

or

 org.freedesktop.FirewallD.InvalidZone: lksflkds

or

 ...

Additional info:

An example from NetworkManager:
org.freedesktop.NetworkManager.UnknownDevice: No device found for the requested iface.

Comment 2 Daniel Kopeček 2014-08-27 11:36:06 UTC
After reading more about reporting D-Bus errors, I think that FirewallD is diverging a bit in this area. Is there a reason to use just one D-Bus error name,  e.g. "org.fedoraproject.FirewallD1.Error", and then differentiating the specific errors by using an extra field, e.g. "INVALID_ZONE"?

The D-Bus specification at http://dbus.freedesktop.org/doc/dbus-specification.html says the following:
------------
Error names have the same restrictions as interface names.

Error names have the same naming conventions as interface names, and often  contain .Error.; for instance, the owner of example.com might define the errors com.example.MusicPlayer.Error.FileNotFound and com.example.MusicPlayer.Error.OutOfMemory. The errors defined by D-Bus itself, such as org.freedesktop.DBus.Error.Failed, follow a similar pattern.
------------

Event the GlibMM/Gio API expects that the application will conform to this by providing a call to return D-Bus errors which accepts just an error name in the form "foo.bar.domain.SpecificError" and a error message.

Comment 3 Fedora Update System 2014-10-14 16:49:11 UTC
firewalld-0.3.12-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/firewalld-0.3.12-1.fc21

Comment 4 Fedora Update System 2014-10-14 16:50:22 UTC
firewalld-0.3.12-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/firewalld-0.3.12-1.fc20

Comment 5 Fedora Update System 2014-10-16 17:16:55 UTC
Package firewalld-0.3.12-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing firewalld-0.3.12-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12912/firewalld-0.3.12-1.fc21
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2014-11-01 01:41:59 UTC
firewalld-0.3.12-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2014-11-01 16:25:58 UTC
firewalld-0.3.12-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.