Bug 1135130 - Review Request: rubygem-logstasher - Awesome rails logs
Summary: Review Request: rubygem-logstasher - Awesome rails logs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josef Stribny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-28 21:38 UTC by František Dvořák
Modified: 2016-01-04 05:53 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-17 18:56:30 UTC
Type: ---
Embargoed:
jstribny: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description František Dvořák 2014-08-28 21:38:29 UTC
Spec URL: http://scientific.zcu.cz/fedora/rubygem-logstasher-0.6.0-1/rubygem-logstasher.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-logstasher-0.6.0-1/rubygem-logstasher-0.6.0-1.fc22.src.rpm
Description: Logstasher gem generates logstash compatible logs in JSON format. It can also easily log events from Rails.
Fedora Account System Username: valtri

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7477701

Comment 1 Josef Stribny 2014-09-08 07:29:08 UTC
I will take it for a review.

Comment 2 Josef Stribny 2014-09-08 08:48:00 UTC
It seems that logstasher depends heavily on ActiveSupport:

irb(main):001:0> require 'logstasher'
LoadError: cannot load such file -- active_support/core_ext/class/attribute
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/share/gems/gems/logstasher-0.6.0/lib/logstasher/log_subscriber.rb:1:in `<top (required)>'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/share/gems/gems/logstasher-0.6.0/lib/logstasher.rb:2:in `<top (required)>'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:135:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:135:in `rescue in require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:144:in `require'
	from (irb):1
	from /usr/bin/irb:11:in `<main>'

but ActiveSupport is not mentioned among dependencies. So your package installs, but doesn't run. I suggest to report this to upstream and add the dependency in the meantime.

Comment 3 František Dvořák 2014-09-10 20:37:43 UTC
Thanks! Updated version:

Spec URL: http://scientific.zcu.cz/fedora/rubygem-logstasher-0.6.0-2/rubygem-logstasher.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-logstasher-0.6.0-2/rubygem-logstasher-0.6.0-2.fc22.src.rpm

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7565702

changelog:
* Wed Sep 10 2014 František Dvořák <valtri.cz> - 0.6.0-2
- Explicit runtime dependency on activesupport

There is 0.6.1 version already at rubygems.org, but archive seems broken and there are no big changes since 0.6.0.

Comment 4 Josef Stribny 2014-09-16 10:26:09 UTC
> There is 0.6.1 version already at rubygems.org, but archive seems broken and there are no big changes since 0.6.0.

It's not broken, it contains just the necessary lib dir. Could you ask upstream to include the license in the released .gem file? And please update the specfile for 0.6.1, it seems that they won't ship spec anymore so if you prepare the spec for it, other future updates will be easier.

Comment 5 František Dvořák 2014-09-16 11:11:01 UTC
Oh, I see. :-) Asked upstream in https://github.com/shadabahmed/logstasher/issues/43 , they should definitely know about it.

For Fedora, I think we can easily comply with the licensing guidelines even now. I'll prepare the new version.

Comment 7 Josef Stribny 2014-09-17 13:03:45 UTC
The package builds, installs, runs. Rpmlint doesn't complain and the spec looks sane. ==> APPROVED.

Comment 8 František Dvořák 2014-09-17 14:45:25 UTC
New Package SCM Request
=======================
Package Name: rubygem-logstasher
Short Description: Awesome rails logs
Upstream URL: https://github.com/shadabahmed/logstasher
Owners: valtri
Branches: f21
InitialCC:

Comment 9 Gwyn Ciesla 2014-09-17 16:54:38 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2014-09-17 18:54:45 UTC
rubygem-logstasher-0.6.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/rubygem-logstasher-0.6.1-1.fc21

Comment 11 Fedora Update System 2014-09-23 04:46:25 UTC
rubygem-logstasher-0.6.1-1.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.