Bug 113662 - old broken K&R code duplicated ?
Summary: old broken K&R code duplicated ?
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Canna   
(Show other bugs)
Version: 1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Akira TAGOH
QA Contact: Bill Huang
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-01-16 09:49 UTC by d.binderman
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version: 3.7p1-2
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2004-01-19 01:50:25 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description d.binderman 2004-01-16 09:49:02 UTC
Description of problem:

I've just been having a look at package Canna-3.6-24 from Fedora.
I found

[root@localhost SPECS]# grep searchdesc
../BUILD/Canna-3.6/Canna36p4/dic/ideo/pubdic/pod.c
searchdesc(hin, tan, yom)
    dp = searchdesc(dhinshi);

This means that routine searchdesc is defined with three parameters,
but only gets called with one. This is a problem for any
use of parameters tan & yom in the searchdesc routine.

Suggest remove parameters tan & yom. The source code is

static struct descpack *
searchdesc (hin, tan, yom)
     Wchar *hin, **tan, **yom;
{

Suggest also use ISO function prototypes. K&R code has been deprecated
for about fifteen years now.

static struct descpack *
searchdesc ( Wchar * hin)
{

This source code, and so this problem, seems to be duplicated from
package FreeWnn.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Akira TAGOH 2004-01-19 01:50:25 UTC
Fixed in 3.7p1-2.


Note You need to log in before you can comment on or make changes to this bug.