Bug 114114 - spec file patch for disable pcre correctly
Summary: spec file patch for disable pcre correctly
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdelibs
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Ngo Than
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-01-22 18:36 UTC by kanagawa jigorou
Modified: 2007-11-30 22:10 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2004-01-23 17:19:22 UTC


Attachments (Terms of Use)

Description kanagawa jigorou 2004-01-22 18:36:06 UTC
It seems that the package kdelibs in development repository
(currently, kdelibs-3.1.95) hasn't been disabled pcre option correctly.

In kdelibs.spec, it is declared

%define pcre 0

on the top, but wrote

%if %{pcre}
   --disable-pcre
%endif

in "%configure" section.
Doesn't it lack " == 0" ?


Here is diff result between original and fixed.

[jigorou@hogehost SPECS]$ diff -ru kdelibs.spec.or kdelibs.spec
--- kdelibs.spec.or     2004-01-21 20:29:45.000000000 +0900
+++ kdelibs.spec        2004-01-23 02:16:56.090542024 +0900
@@ -8,8 +8,8 @@
 %define debug 0
 %define final 0

-%define qt_version 3.2.2
-%define arts_version 1.1.94
+%define qt_version 3.2.3
+%define arts_version 1.1.95

 %define kde_major_version 3

@@ -199,7 +199,7 @@
 %if %{dnotify}
    --enable-dnotify \
 %endif
-%if %{pcre}
+%if %{pcre} == 0
    --disable-pcre \
 %endif
    --disable-rpath
[jigorou@hogehost SPECS]$

Comment 1 Ngo Than 2004-01-23 17:18:49 UTC
it's fixed in 3.1.95-0.4. thanks for your report.


Note You need to log in before you can comment on or make changes to this bug.