Bug 1142325 - Platform unit tests require qpidtoollibs to be installed
Summary: Platform unit tests require qpidtoollibs to be installed
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: 2.4.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: 2.6.0
Assignee: Jeremy Cline
QA Contact: Irina Gulina
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-16 15:00 UTC by Randy Barlow
Modified: 2015-02-28 22:20 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-28 22:20:32 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Pulp Redmine 530 0 None None None Never

Description Randy Barlow 2014-09-16 15:00:44 UTC
Description of problem:
The platform unit tests will not pass if qpidtoollibs is not installed. This is unfriendly for community developers who wish to use rabbitmq. It would be better if the tests ran only if qpidtoollibs is installed.

Version-Release number of selected component (if applicable):
2.4.0-1

How reproducible:
Every time.

Steps to Reproduce:
1. Ensure that python-qpid-qmf is not installed.
2. Run the platform test suite.

Actual results:
======================================================================
ERROR: test_migrate (unit.server.db.migrations.test_migration_0009.TestMigration)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/mock.py", line 1216, in patched
    arg = patching.__enter__()
  File "/usr/lib/python2.6/site-packages/mock.py", line 1275, in __enter__
    original, local = self.get_original()
  File "/usr/lib/python2.6/site-packages/mock.py", line 1263, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <module 'pulp.server.db.migrations.0009_qpid_queues' from '/home/rbarlow/devel/pulp/server/pulp/server/db/migrations/0009_qpid_queues.py'> does not have the attribute 'BrokerAgent'

Expected results:
The Qpid specific tests should be skipped.

Comment 1 Brian Bouterse 2014-09-16 15:17:36 UTC
The tests could also be written to not require any 3rd party libraries.

Comment 2 Jeremy Cline 2014-12-11 15:17:51 UTC
https://github.com/pulp/pulp/pull/1418

Comment 3 Chris Duryee 2014-12-23 20:53:02 UTC
fixed in pulp 2.6.0-0.2.beta

Comment 4 Irina Gulina 2015-02-25 14:25:44 UTC
>> uname -r
3.17.1-302.fc21.x86_64

>> rpm -qa python-qpid-qmf
$ 

>> ./run-tests.py 
Running flake8
Running Unit Tests

.....
....


Ran 3236 tests in 214.981s

OK

Comment 5 Brian Bouterse 2015-02-28 22:20:32 UTC
Moved to https://pulp.plan.io/issues/530


Note You need to log in before you can comment on or make changes to this bug.