Description of problem: I just tried to compile package gnome-media-2.4.0-2, from Redhat Fedora Core 1. The compiler said 1. cddb-slave.c:824: warning: too few arguments for format The source code is g_print ("CDDB: Unknown response code: %d\n"); Clearly broken code sinec one %d specifier, and no integer supplied. 2. cddb-slave.c:973: warning: format argument is not a pointer (arg 5) The source code is g_warning ("Could not connect to %s:%s", data->cddb->priv->server, data->cddb->priv->port); Suspect swap second %s for %d, because port is an integer. 3. cddb-disclosure.c(119): remark #592: variable "indicator_size" is used before its value is set The source code is *x = widget->allocation.x + widget->allocation.width - (indicator_size + *x - widget->allocation.x); But indicator_size doesn't get written to anywhere. 4. prefs.c(60): warning #1011: missing return statement at end of non-void function "reset_labels" The source code is gtk_list_store_set (GTK_LIST_STORE (model), iter, 0, original, -1); } 5. gsr-window.c(435): warning #1011: missing return statement at end of non-void function "get_encoder_for_mimetype" The source code is } } 6. gsr-window.c(1182): warning #117: non-void function "seek_to" should return a value The source code is if (old_state == GST_STATE_READY) { return; } There is a return type for this function. A value should be returned. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
All of these look to be fixed in gnome-media 2.6.0.