Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1145317

Summary:	missing author in metadata.json makes sync fail
Product:	[Retired] Pulp	Reporter:	cristi falcas <cristi.falcas>
Component:	puppet-support	Assignee:	pulp-bugs
Status:	CLOSED NOTABUG	QA Contact:	pulp-qe-list
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	2.4.0	CC:	mhrivnak
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-24 13:26:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description cristi falcas 2014-09-22 20:04:33 UTC

Description of problem:
If the author element in metadata.json is missing, the entire sync fails.

This seems a little harsh, since "puppet module build ." didn't complained about it.

Following the exception:
 INFO: Initializing build directory for repository <puppet_optymyze>
 v-repo-op-02.optymyze.net pulp: pulp.server.async.worker_watcher:DEBUG: received 'worker-heartbeat' from resource_manager.net at time: 2014-09-22 19:59:30.274436
 v-repo-op-02.optymyze.net pulp: pulp.server.async.worker_watcher:DEBUG: received 'worker-heartbeat' from reserved_resource_worker-0.net at time: 2014-09-22 19:59:30.474254
 ERROR: Exception during modules step for repository <puppet_optymyze>
 ERROR: Traceback (most recent call last):
 ERROR:   File "/usr/lib/python2.7/site-packages/pulp_puppet/plugins/distributors/publish.py", line 108, in _modules_step
 ERROR:     self._symlink_modules(modules)
 ERROR:   File "/usr/lib/python2.7/site-packages/pulp_puppet/plugins/distributors/publish.py", line 231, in _symlink_modules
 ERROR:     served_relative_path = self._build_relative_path(module)
 ERROR:   File "/usr/lib/python2.7/site-packages/pulp_puppet/plugins/distributors/publish.py", line 254, in _build_relative_path
 ERROR:     subs = (module.unit_key['author'][0], module.unit_key['author'])
 ERROR: IndexError: string index out of range


Version-Release number of selected component (if applicable):
2.4.0

How reproducible:
Always

Steps to Reproduce:
1. Make a puppet module with author element empty in metadata.json
2. Use pulp-puppet-module-builder to import it in a local repo
3. Try to sync the local repo in pulp

Actual results:


Expected results:


Additional info:

Comment 1 Michael Hrivnak 2014-09-24 13:26:50 UTC

As far as I know, you cannot publish a module on puppet forge without there being an author specified. Thus we aren't supporting that in pulp either. Feel free to re-open if you think there's a strong use case for not having an author.