Spec URL: http://mcpierce.fedorapeople.org/rpms/python-pyngus.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/python-pyngus-1.1.0-0.fc20.src.rpm Description: Callback API implemented over Proton Fedora Account System Username: mcpierce
I will take this. I should have it reviewed by tomorrow evening.
Below is the "first pass" review - please take a look. Should be quick fixes Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ---> This is mentioned in the python packaging guidelines. But there is nothing built here. Only install. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. ---> License file not included in the source tarball but license is mentioned. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache (v2.0)". Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/1146575-python- pyngus/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed ---> Older EL releases support? If not, please consider modernizing the spec. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. ---> Here, spec file in the URL and SRPM differ - please make sure they are consistent. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ---> Please check with upstream about this [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7707620 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-pyngus-1.1.0-0.fc22.noarch.rpm python-pyngus-1.1.0-0.fc22.src.rpm python-pyngus.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-pyngus python-pyngus.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/mukundan/personal/pkgs/reviews/1146575-python-pyngus/srpm/python-pyngus.spec 2014-09-26 20:10:06.806111483 -0500 +++ /home/mukundan/personal/pkgs/reviews/1146575-python-pyngus/srpm-unpacked/python-pyngus.spec 2014-09-25 08:51:17.000000000 -0500 @@ -14,5 +14,5 @@ BuildRequires: python-setuptools -Requires: python-qpid-proton +Requires: python Requires: qpid-proton-c ---> Please ensure they are the same. Requires -------- python-pyngus (rpmlib, GLIBC filtered): python python(abi) qpid-proton-c Provides -------- python-pyngus: python-pyngus Source checksums ---------------- http://pypi.python.org/packages/source/p/pyngus/pyngus-1.1.0.tar.gz : CHECKSUM(SHA256) this package : b85b2c47f66041bed624cdc468d09f8bd01dcd500c7cbd9d3ffa4c128de917f2 CHECKSUM(SHA256) upstream package : b85b2c47f66041bed624cdc468d09f8bd01dcd500c7cbd9d3ffa4c128de917f2 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1146575 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Okay, specfile in the updated SRPM is the same as the one I'm uploading. Added egg info as docs for the package. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/python-pyngus.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/python-pyngus-1.1.0-0.1.fc20.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7718462
* Changes pointed out are done * Running fedora-review again does not throw any other problems. Upon looking further, looks good to me. Package APPROVED.
(In reply to Mukundan Ragavan from comment #4) > * Changes pointed out are done > > * Running fedora-review again does not throw any other problems. > > Upon looking further, looks good to me. Package APPROVED. Thank you! New Package SCM Request ======================= Package Name: python-pyngus Short Description: Callback API implemented over Proton Upstream URL: https://github.com/kgiusti/pyngus Owners: mcpierce Branches: f20 f21 epel7 InitialCC:
Git done (by process-git-requests).
Package already built successfully. Closing.