Bug 1148365 - Review Request: perl-URI-Encode - Simple percent Encoding/Decoding
Summary: Review Request: perl-URI-Encode - Simple percent Encoding/Decoding
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Denis Fateyev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-01 09:46 UTC by David Dick
Modified: 2014-10-23 16:07 UTC (History)
2 users (show)

Fixed In Version: perl-URI-Encode-0.09-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-16 02:05:44 UTC
Type: ---
Embargoed:
denis: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Dick 2014-10-01 09:46:38 UTC
Spec URL: https://ddick.fedorapeople.org/packages/perl-URI-Encode.spec
SRPM URL: https://ddick.fedorapeople.org/packages/perl-URI-Encode-0.09-1.fc20.src.rpm
Description: Simple percent Encoding/Decoding
Fedora Account System Username: ddick

Comment 2 Denis Fateyev 2014-10-04 20:59:28 UTC
The URL and Source0 are usable. Ok.
The source archive is original (SHA-256: 532a09f04da80b28d420f3ff52eb4e489f10656e527a967ca131ce683b83bcc3). Ok.
Summary and description are basically Ok - but I would improve them to be more informative for search, especially, the description.

License verified from lib/URI/Encode.pm.
GPL+ or Artistic. License is Ok.

XS code not present, BuildArch is "noarch": Ok.
Build log used for check (Koji rawhide build):
https://kojipkgs.fedoraproject.org/work/tasks/8107/7768107/build.log
Build-time dependencies are Ok.
All tests passed. Ok.

$ rpmlint perl-URI-Encode-0.09-1.fc22.noarch.rpm perl-URI-Encode-0.09-1.fc22.src.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint is Ok.

$ rpm -q -lv -p perl-URI-Encode-0.09-1.fc22.noarch.rpm 
drwxr-xr-x    2 root  root     0 Oct  5 02:10 /usr/share/doc/perl-URI-Encode
-rw-r--r--    1 root  root  1042 Mar  5  2013 /usr/share/doc/perl-URI-Encode/Changes
-rw-r--r--    1 root  root 18407 Mar  5  2013 /usr/share/doc/perl-URI-Encode/LICENSE
-rw-r--r--    1 root  root  3793 Mar  5  2013 /usr/share/doc/perl-URI-Encode/README
-rw-r--r--    1 root  root  3635 Oct  5 02:10 /usr/share/man/man3/URI::Encode.3pm.gz
drwxr-xr-x    2 root  root     0 Oct  5 02:10 /usr/share/perl5/vendor_perl/URI
-rw-r--r--    1 root  root  8158 Oct  5 02:10 /usr/share/perl5/vendor_perl/URI/Encode.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-URI-Encode-0.09-1.fc22.noarch.rpm  | sort -f | uniq -c
      1 perl >= 0:5.008001
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(base)
      1 perl(Carp)
      1 perl(Encode) >= 2.12
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Requires are Ok.

rpm -q --provides -p perl-URI-Encode-0.09-1.fc22.noarch.rpm  | sort -f | uniq -c
      1 perl(URI::Encode) = 0.09
      1 perl-URI-Encode = 0.09-1.fc22
Provides are Ok.

Package can be built successfully in Rawhide and EPEL7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=7768106
https://koji.fedoraproject.org/koji/taskinfo?taskID=7768288
Build is Ok.

Package is in line with Fedora and Perl packaging guidelines.

Review result: package is APPROVED.
The recommendation is only to improve package's summary and description.

Comment 3 David Dick 2014-10-06 19:38:52 UTC
Thanks Denis.

New Package SCM Request
=======================
Package Name: perl-URI-Encode
Short Description: Percent encoding/decoding for URIs
Upstream URL: http://search.cpan.org/dist/URI-Encode/
Owners: ddick
Branches: f20, f21, epel7, el6
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-10-07 12:10:07 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-10-07 19:31:24 UTC
perl-URI-Encode-0.09-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-URI-Encode-0.09-1.fc20

Comment 6 Fedora Update System 2014-10-07 19:31:51 UTC
perl-URI-Encode-0.09-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-URI-Encode-0.09-1.fc21

Comment 7 Fedora Update System 2014-10-07 19:32:18 UTC
perl-URI-Encode-0.09-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-URI-Encode-0.09-1.el6

Comment 8 Fedora Update System 2014-10-07 19:32:45 UTC
perl-URI-Encode-0.09-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-URI-Encode-0.09-1.el7

Comment 9 Fedora Update System 2014-10-08 00:42:01 UTC
perl-URI-Encode-0.09-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 10 Fedora Update System 2014-10-16 02:05:44 UTC
perl-URI-Encode-0.09-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2014-10-17 08:36:39 UTC
perl-URI-Encode-0.09-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 12 Fedora Update System 2014-10-23 16:06:07 UTC
perl-URI-Encode-0.09-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 13 Fedora Update System 2014-10-23 16:07:05 UTC
perl-URI-Encode-0.09-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.