Bug 1153135 - New bundled files on Icecat
Summary: New bundled files on Icecat
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: icecat
Version: rawhide
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
Assignee: Antonio T. (sagitter)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DuplicSysLibsTracker
TreeView+ depends on / blocked
 
Reported: 2014-10-15 16:51 UTC by Antonio T. (sagitter)
Modified: 2015-12-09 17:41 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 20:02:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Antonio T. (sagitter) 2014-10-15 16:51:57 UTC
Description of problem:
Icecat-24.0 currently can provide some bundled files (https://fedorahosted.org/fpc/ticket/391). That are

Provides:       bundled(libtheora) = 1.1.1
Provides:       bundled(libvorbis) = 1.3.4
Provides:       bundled(libogg)    = 1.3.0
Provides:       bundled(opus)      = 1.1
Provides:       bundled(xulrunner) = 24.0
Provides:       bundled(expat)     = 2.1.0
Provides:       bundled(graphite2) = 1.2.3
Provides:       bundled(ots) = 0.5.0
Provides:       bundled(hurfbuzz) = 0.9.2
Provides:       bundled(soundtouch) = 1.7.3
Provides:       bundled(snappy) = 1.0.4
Provides:       bundled(double-conversion) = 1.1.3 

The new IceCat-31.1.1 provides its nspr nss libraries in a private library directory even though IceCat's build system has configuration options to compile against NSS NSPR system libraries.
Also IceCat's make-install installs header files 
 
Provides:       bundled(libtheora) = 1.2.0
Provides:       bundled(libvorbis) = 1.3.4
Provides:       bundled(libogg)    = 1.3.0
Provides:       bundled(libjpeg) = 1.3.1
Provides:       bundled(opus)      = 1.1
Provides:       bundled(xulrunner) = 31.1
Provides:       bundled(ots) = 0.5.0
Provides:       bundled(snappy) = 1.0.4
Provides:       bundled(libicu) = 52.1  patched in mozilla
Provides:       bundled(nss) = 3.16.2
Provides:       bundled(nspr) = 4.10.6
Provides:       bundled(graphite2) = 1.2.4   patched in mozilla
Provides:       bundled(harfbuzz) = 0.9.2    patched in mozilla
Provides:       bundled(cairo) = 1.9.5    patched in mozilla
Provides:       bundled(libmkv) = 1.3.0    patched in mozilla
Provides:       bundled(double-conversion) = 2.0.0  patched in mozilla

Here a scratch build against Fedora 20:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7866908

Comment 1 Kevin Fenzi 2014-10-21 18:50:00 UTC
Even though you are putting them in a private directory, rpm still finds the nss libraries and adds them to provides. ;( 

This is causing icecat to be pulled into buildroots instead of the real nss libraries. ;( 

Please filter these deps or use the system libraries asap!

Comment 2 Antonio T. (sagitter) 2014-10-21 20:48:19 UTC
I'm completing a new packaging release with fixes.
There was something wrong on the latest build.

Comment 3 Kevin Fenzi 2014-10-21 21:35:23 UTC
Thanks. Yeah, it happens... ;( 

I also am doing a scratch build now to see if I can filter out those provides... 

would you like me to push that as a short term fix for rawhide until you can sort out the rest? 

Or are you likely to have a new release soon?

Comment 4 Antonio T. (sagitter) 2014-10-21 21:56:43 UTC
(In reply to Kevin Fenzi from comment #3)
> Thanks. Yeah, it happens... ;( 
> 
> I also am doing a scratch build now to see if I can filter out those
> provides... 
> 
> would you like me to push that as a short term fix for rawhide until you can
> sort out the rest? 

Better if we add NSS/NSPR options directly to 'configure'.
mozconfig needs additional cleanups (old options are still present). 

> 
> Or are you likely to have a new release soon?

icecat-31.2.0 is out.

Comment 5 Kevin Fenzi 2014-10-21 22:10:29 UTC
ok, my goal is to fix things so icecat stops getting pulled into every build root and being used for building things. ;( 

"1960 builds used icecat in f22 buildroot"

The quickest way we can do that would be fine with me.

Comment 6 Antonio T. (sagitter) 2014-10-21 22:59:50 UTC
(In reply to Kevin Fenzi from comment #5)
> ok, my goal is to fix things so icecat stops getting pulled into every build
> root and being used for building things. ;( 
> 
> "1960 builds used icecat in f22 buildroot"

I'm pushing a new release that should fix problems with NSS.
I'm really sorry for this situation.

Comment 7 Lubomir Rintel 2014-10-22 12:36:08 UTC
Seems like new build failed on arm.

Untagged the problematic from f22 for now.

Comment 8 Antonio T. (sagitter) 2014-10-26 08:42:29 UTC
(In reply to Antonio Trande from comment #6)
> (In reply to Kevin Fenzi from comment #5)
> > ok, my goal is to fix things so icecat stops getting pulled into every build
> > root and being used for building things. ;( 
> > 
> > "1960 builds used icecat in f22 buildroot"
> 
> I'm pushing a new release that should fix problems with NSS.
> I'm really sorry for this situation.

http://koji.fedoraproject.org/koji/buildinfo?buildID=587781

This release should to have fixed NSS issue. Package needs further adjustments I will do as soon as I come back to home.

Comment 9 Antonio T. (sagitter) 2014-10-26 08:47:29 UTC
Bundled files from latest release:

Provides:       bundled(libtheora) = 1.2.0
Provides:       bundled(libvorbis) = 1.3.4
Provides:       bundled(libogg)    = 1.3.0
Provides:       bundled(opus)      = 1.1
Provides:       bundled(xulrunner) = 31.0
Provides:       bundled(ots) = 0.5.0
Provides:       bundled(snappy) = 1.0.4
Provides:       bundled(graphite2) = 1.2.4
Provides:       bundled(harfbuzz) = 0.9.2
Provides:       bundled(libmkv) = 1.3.0
Provides:       bundled(double-conversion) = 2.0.0

Comment 10 Kevin Fenzi 2014-10-27 12:45:11 UTC
(In reply to Lubomir Rintel from comment #7)
> Seems like new build failed on arm.
> 
> Untagged the problematic from f22 for now.

Note that this should not have been done. Once a package goes out in a rawhide compose, it shouldn't be untagged. :(

Comment 11 Antonio T. (sagitter) 2015-12-09 17:41:49 UTC
This ticket is made obsoleted by updates to the bundling policy.
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Some_reasons_you_might_be_granted_an_exception


Note You need to log in before you can comment on or make changes to this bug.