Bug 1153731 - Review Request: golang-github-tonnerre-golang-pretty - Pretty printing for Go values http://godoc.org/github.com/kr/pretty
Summary: Review Request: golang-github-tonnerre-golang-pretty - Pretty printing for Go...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lokesh Mandvekar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-16 16:23 UTC by Jan Chaloupka
Modified: 2014-11-01 16:36 UTC (History)
2 users (show)

Fixed In Version: golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-28 06:43:57 UTC
Type: ---
Embargoed:
lsm5: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jan Chaloupka 2014-10-16 16:23:00 UTC 
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-tonnerre-golang-pretty/golang-github-tonnerre-golang-pretty.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-tonnerre-golang-pretty/golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc20.src.rpm

Description: Pretty printing for Go values http://godoc.org/github.com/kr/pretty

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7883898

$ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-tonnerre-golang-pretty-devel-0-0.1.gite7fccc0.fc20.noarch.rpm golang-github-tonnerre-golang-pretty.spec
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Comment 1 Lokesh Mandvekar 2014-10-16 16:45:36 UTC 
Looks like the MIT license file should have this line on top: 
"The MIT License (MIT)" ..perhaps that should be reported upstream, kr/pretty has that corrected btw.

But apart from that, specfile conforms to current golang packaging draft. Only source files packaged for now, but that may change as packaging draft evolves. This is a fork of kr/pretty but paths for installed files don't conflict at the time of this writing. Package approved.
Comment 2 Jan Chaloupka 2014-10-16 18:54:14 UTC 
New Package SCM Request
=======================
Package Name: golang-github-tonnerre-golang-pretty
Short Description: Pretty printing for Go values http://godoc.org/github.com/kr/pretty
Upstream URL: https://github.com/tonnerre/golang-pretty
Owners: jchaloup lsm5 vbatts
Branches: f21 f20 f19 el6
InitialCC: golang-sig
Comment 3 Gwyn Ciesla 2014-10-16 19:47:06 UTC 
Git done (by process-git-requests).
Comment 4 Fedora Update System 2014-10-16 20:59:56 UTC 
golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc20
Comment 5 Fedora Update System 2014-10-16 21:00:36 UTC 
golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc21
Comment 6 Fedora Update System 2014-10-17 19:43:46 UTC 
golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc21 has been pushed to the Fedora 21 testing repository.
Comment 7 Fedora Update System 2014-10-28 06:43:57 UTC 
golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc20 has been pushed to the Fedora 20 stable repository.
Comment 8 Fedora Update System 2014-11-01 16:36:32 UTC 
golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc21 has been pushed to the Fedora 21 stable repository.
Note You need to log in before you can comment on or make changes to this bug.