Created attachment 947696 [details] journal output Description of problem: When a role deployment fails due to a typo or otherwise misconfigured settings-file, rolekit is unable to redeploy with a corrected file or decommission the failed deployment. Version-Release number of selected component (if applicable): rolekit-0.1.0-2.fc21.noarch How reproducible: 100% Steps to Reproduce: 1. Create a settings.json file with incorrect information (Place quotes around an INT, have an incorrect IP address for primary_ip) 2. Run 'rolectl deploy --settings-file ./settings.json domaincontroller' 3. When deployment fails with "Error: COMMAND_FAILED: 512". 4. Correct settings.json file. 5. Attempt 'rolectl redeploy --settings.file domaincontroller/1' 6. Attempt 'rolectl decommission domaincontroller/1' Actual results: redeploy will fail with "Error: UNKNOWN_SETTING: admin_password" decommission will fail with "Error: COMMAND_FAILED: 256" Expected results: For redeploy, the deployment process should run again and complete. For decommission, the role and instance should be deleted. Additional info: Attaching the journal output and the settings.json file I used.
Created attachment 947697 [details] Settings file
There are fixes for this already in rolekit GIT: Remove instance again if verification of settings failed https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=1d61920004de07be405061c0e44352bc3e2ec3ff rolebase, rolectl: New force option for decommission https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=eae4e203c180a1f5f18db6c957631b2086476776 With the first fix, the instance will be removed again in case of settings failures that can be detected in rolekit. There are also checks in the roles that rolekit can not detect easily, because they are done in deploy. In this case and also other decommission errors, there is a new force option for decommission.
rolekit-0.1.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rolekit-0.1.2-1.fc21
rolekit-0.1.2-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.