RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1159875 - [RFE] rpmsodiff return non-zero if rpms differ
Summary: [RFE] rpmsodiff return non-zero if rpms differ
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: rpmdevtools
Version: 8.0
Hardware: All
OS: Linux
unspecified
low
Target Milestone: rc
: 8.0
Assignee: Thomas Woerner
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
: 1195388 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-03 14:10 UTC by Pat Riehecky
Modified: 2019-05-22 05:15 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of: 1004450
Environment:
Last Closed: 2019-03-13 21:27:42 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Pat Riehecky 2014-11-03 14:10:27 UTC
+++ This bug was initially created as a clone of Bug #1004450 +++

Description of problem: rpmsodiff provides the difference information I want, but I can't script a check to determine if the rpms match or if they do not.


Version-Release number of selected component (if applicable):rpmdevtools-8.3-5.fc20


How reproducible: always


Steps to Reproduce:
1. run against two identical rpms
2. echo $?
3. run against two different rpms
4. echo $?
5. note it is the same

Actual results:
return code is 0

Expected results:
Like 'diff' if the files don't match return non-zero

Additional info:

--- Additional comment from  on 2013-11-25 11:01:43 EST ---

Just wondering if there were any thoughts on this patch.

--- Additional comment from Ville Skyttä on 2013-11-26 02:46:48 EST ---

Sorry about the delay. The reason I haven't done anything about this yet is that rpmdevtools is not the upstream for rpmsodiff, and I'd prefer this to see fixed upstream instead of carrying a modified version in rpmdevtools.

I suppose the best upstream contacts are the people listed at http://packages.altlinux.org/en/Sisyphus/srpms/qa-robot, will try to ping them.

--- Additional comment from Gleb Fotengauer-Malinovskiy on 2013-11-26 10:37:03 EST ---

(In reply to jcpunk from comment #0)
> Created attachment 793750 [details]
> Patch to implement behavior

Thank you for idea!
But your patch doesn't work in some cases:
1. in case of no common sonames, it should return 1.
2. in case of common sonames and if symbols differ. In 'while' loop works in subshell, so RETVAL=1 does not affect return code.

My patch works in this cases:
http://git.altlinux.org/people/glebfm/packages/qa-robot.git?p=qa-robot.git;a=shortlog;h=refs/heads/master

--- Additional comment from Ville Skyttä on 2013-11-26 12:16:24 EST ---

Thanks for looking into this, Gleb!

I'll leave this bug open for tracking purposes until we ship rpmsodiff that includes this feature in Fedora.

--- Additional comment from Fedora Update System on 2014-10-20 14:48:32 EDT ---

rpmdevtools-8.5-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/rpmdevtools-8.5-1.fc21

--- Additional comment from Fedora Update System on 2014-10-21 13:24:12 EDT ---

Package rpmdevtools-8.5-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing rpmdevtools-8.5-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-13380/rpmdevtools-8.5-1.fc21
then log in and leave karma (feedback).

--- Additional comment from Fedora Update System on 2014-11-01 12:51:34 EDT ---

rpmdevtools-8.5-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 3 Karel Srot 2015-12-17 12:47:41 UTC
*** Bug 1195388 has been marked as a duplicate of this bug. ***

Comment 4 Dmitri Pal 2019-03-13 21:27:42 UTC
This issue has been addressed upstream many years ago. By now it definitely made its way into the RHEL. Closing.


Note You need to log in before you can comment on or make changes to this bug.