Created attachment 954256 [details] Patch to add printsupport as a dependency of QtWebKitWidgets Description of problem: I'm in the process of porting python-qt5 to CentOS 7, so I took the src.rpm out of Fedora 21 beta. I have all the dependencies compiled and installed fine, but on building python-qt5, I get a compilation error. After I figured out what the problem was and created the attached patch, a quick google showed thatboth Gentoo and OpenSUSE have patches covering this one already. I've also found references to the same compilation error occuring on Mac OS X. So it's a widespread problem with the upstream distribution which the various vendors are patching for. I would otherwise have logged this one under EPEL, but it seems that this would affect Fedora as well, given the widespread upstream nature. Version-Release number of selected component (if applicable): 5.3.2-1.fc21 How reproducible: Always on CentOS 7.x. I can't figure out why it would compile on Fedora too (but I'm guessing it must, given there's a package in Fedora 21 beta). Steps to Reproduce: 1. rpmbuild --rebuild python-qt5-5.3.2-1.fc21.src.rpm Actual results: g++ -c -m64 -pipe -fno-exceptions -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -O2 -Wall -W -D_REENTRANT -fPIC -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DQT_NO_DEBUG -DQT_PLUGIN -DQT_WEBKITWIDGETS_LIB -DQT_WEBKIT_LIB -DQT_WIDGETS_LIB -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/usr/lib64/qt5/mkspecs/linux-g++-64 -I. -I. -isystem /usr/include/python3.4m -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWebKitWidgets -isystem /usr/include/qt5/QtWebKit -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore -I. -o sipQtWebKitWidgetsQWebView.o sipQtWebKitWidgetsQWebView.cpp sip/QtPrintSupport/qprinter.sip:28:22: fatal error: qprinter.h: No such file or directory compilation terminated. make: *** [sipQtWebKitWidgetsQWebView.o] Error 1 This is caused by: [root@nathanr-centos7 QtWebKitWidgets]# cat QtWebKitWidgets.pro | grep QT QT += webkitwidgets [root@nathanr-centos7 QtWebKitWidgets]# which should be: QT += webkitwidgets printsupport This is fixed by the attached patch. Expected results: Compiles and produces RPM. Additional info: A quick google says that Gentoo have apparently patched this one: https://www.mail-archive.com/gentoo-commits@lists.gentoo.org/msg63799.html As have OpenSUSE: http://lists.opensuse.org/opensuse-commit/2014-09/msg00462.html
Thanks, I'll look into it.
What version(s) of Qt5 are you building against?
Nevermind, looks like this indeed is required univerisally due to recent overlinking fixes from Qt5 upstream.
fixed builds in rawhide, I'll issue f21 updates shortly.
python-qt5-5.3.2-4.fc21,dbus-python-1.2.0-7.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-qt5-5.3.2-4.fc21,dbus-python-1.2.0-7.fc21
Package python-qt5-5.3.2-4.fc21, dbus-python-1.2.0-7.fc21, PyQt4-4.11.2-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-qt5-5.3.2-4.fc21 dbus-python-1.2.0-7.fc21 PyQt4-4.11.2-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-14431/PyQt4-4.11.2-2.fc21,python-qt5-5.3.2-4.fc21,dbus-python-1.2.0-7.fc21 then log in and leave karma (feedback).
python-qt5-5.3.2-4.fc21, dbus-python-1.2.0-7.fc21, PyQt4-4.11.2-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.