Bug 1161121 - python2_sitelib should be python2_sitearch
Summary: python2_sitelib should be python2_sitearch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dbus-python
Version: 21
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-06 12:34 UTC by Nathan Robertson
Modified: 2014-11-12 02:40 UTC (History)
5 users (show)

Fixed In Version: python-qt5-5.3.2-4.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-12 02:40:35 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Change python2_sitelib to python2_sitearch to work on x86_64 (363 bytes, patch)
2014-11-06 12:34 UTC, Nathan Robertson
no flags Details | Diff
centos7 dbus-python patch that accounts for the difference (1.49 KB, patch)
2014-11-06 13:23 UTC, Rex Dieter
no flags Details | Diff

Description Nathan Robertson 2014-11-06 12:34:05 UTC
Created attachment 954428 [details]
Change python2_sitelib to python2_sitearch to work on x86_64

Description of problem:
When rebuilding python-qt5-5.3.2-1.fc21.src.rpm on CentOS 7, it fails due to a bug in the specfile which seems to violate the Fedora python packaging guidelines (http://fedoraproject.org/wiki/Packaging:Python).

The compilation failure is:
[...]
RPM build errors:
    File not found: /root/rpmbuild/BUILDROOT/python-qt5-5.3.2-1.el7.centos.x86_64/usr/lib/python2.7/site-packages/dbus/mainloop/pyqt5.so

The specfile in the %files section has:

%{python2_sitelib}/dbus/mainloop/pyqt5.so

On x86_64 architectures, this is documented to be /usr/lib/python2.X/site-packages. However, the build puts it in:

[root@nathanr-centos7 SPECS]# find ../BUILDROOT/python-qt5-5.3.2-1.el7.centos.x86_64 -name '*.so'
[...]
../BUILDROOT/python-qt5-5.3.2-1.el7.centos.x86_64/usr/lib64/python2.7/site-packages/dbus/mainloop/pyqt5.so
[...]

The reference should be to %{python2_sitearch} not %{python2_sitelib}, which is /usr/lib/python2.X on x86, and /usr/lib64/python2.X on x86_64.

Version-Release number of selected component (if applicable):
python-qt5-5.3.2-1.fc21

Attached is a patch to fix the issue.

Comment 1 Rex Dieter 2014-11-06 13:02:33 UTC
That patch will likely break fedora builds.

I think it depends on how python and python-dbus is setup

Comment 2 Rex Dieter 2014-11-06 13:05:04 UTC
I'll have to take a closer look too, may end up including here some hackery similar to what's currently done in PyQt4:

http://pkgs.fedoraproject.org/cgit/PyQt4.git/tree/PyQt4.spec#n239

Comment 3 Rex Dieter 2014-11-06 13:23:55 UTC
Created attachment 954449 [details]
centos7 dbus-python patch that accounts for the difference

I'll consider adopting this into fedora's dbus-python packaging too, then PyQt4 and python-qt5 will install in the same place

Comment 4 Rex Dieter 2014-11-06 13:25:44 UTC
moving over to dbus-python

Comment 5 Rex Dieter 2014-11-06 16:41:55 UTC
fixed builds in rawhide, I'll issue f21 updates shortly.

Comment 6 Fedora Update System 2014-11-06 18:55:24 UTC
python-qt5-5.3.2-4.fc21,dbus-python-1.2.0-7.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-qt5-5.3.2-4.fc21,dbus-python-1.2.0-7.fc21

Comment 7 Nathan Robertson 2014-11-06 21:37:20 UTC
Those packages (both updated python-qt5 and dbus-python) build on CentOS 7.x as well. Thanks.

Comment 8 Fedora Update System 2014-11-07 05:31:01 UTC
Package python-qt5-5.3.2-4.fc21, dbus-python-1.2.0-7.fc21, PyQt4-4.11.2-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-qt5-5.3.2-4.fc21 dbus-python-1.2.0-7.fc21 PyQt4-4.11.2-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-14431/PyQt4-4.11.2-2.fc21,python-qt5-5.3.2-4.fc21,dbus-python-1.2.0-7.fc21
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2014-11-12 02:40:35 UTC
python-qt5-5.3.2-4.fc21, dbus-python-1.2.0-7.fc21, PyQt4-4.11.2-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.