Spec URL: https://kashyapc.fedorapeople.org/spec-files/python-gertty.spec SRPM URL: https://kashyapc.fedorapeople.org/srpms/python-gertty-1.0.3-1.fc20.src.rpm Description: Gertty is a console-based interface to the Gerrit Code Review system. As compared to the web interface, the main advantages are: (a) Workflow -- the interface is designed to support a workflow similar to reading network news or mail. In particular, it is designed to deal with a large number of review requests across a large number of projects. (b) Offline Use -- Gertty syncs information about changes in subscribed projects to a local database and local git repos. All review operations are performed against that database and then synced back to Gerrit. (c) Speed -- user actions modify locally cached content and need not wait for server interaction. (d) Convenience -- because Gertty downloads all changes to local git repos, a single command instructs it to checkout a change into that repo for detailed examination or testing of larger changes. Fedora Account System Username: kashyapc
Successful koji scratch build ----------------------------- $ koji build --scratch rawhide ../SRPMS/python-gertty-1.0.3-1.fc20.src.rpm Uploading srpm: ../SRPMS/python-gertty-1.0.3-1.fc20.src.rpm [====================================] 100% 00:00:02 74.02 KiB 29.37 KiB/sec Created task: 8166966 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8166966 Watching tasks (this may be safely interrupted)... 8166966 build (rawhide, python-gertty-1.0.3-1.fc20.src.rpm): free 8166966 build (rawhide, python-gertty-1.0.3-1.fc20.src.rpm): free -> open (buildhw-07.phx2.fedoraproject.org) 8166967 buildArch (python-gertty-1.0.3-1.fc20.src.rpm, noarch): open (buildvm-17.phx2.fedoraproject.org) 8166967 buildArch (python-gertty-1.0.3-1.fc20.src.rpm, noarch): open (buildvm-17.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 8166966 build (rawhide, python-gertty-1.0.3-1.fc20.src.rpm): open (buildhw-07.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 8166966 build (rawhide, python-gertty-1.0.3-1.fc20.src.rpm) completed successfully rpmlint looks happy as well --------------------------- $ rpmlint /home/kashyap/rpmbuild/SRPMS/python-gertty-1.0.3-1.fc20.src.rpm python-gertty.spec python-gertty.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce python-gertty.src: W: spelling-error %description -l en_US repos -> ropes, reps, repose python-gertty.src: W: spelling-error %description -l en_US repo -> rope, rep, reps 1 packages and 1 specfiles checked; 0 errors, 3 warnings.
Review: + Package built successful in mock (f22 x86_64) - rpmlint on generated rpms gave output python-gertty.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce python-gertty.noarch: W: spelling-error %description -l en_US repos -> ropes, reps, repose python-gertty.noarch: W: spelling-error %description -l en_US repo -> rope, rep, reps python-gertty.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-gertty/LICENSE python-gertty.noarch: W: no-manual-page-for-binary gertty python-gertty.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce python-gertty.src: W: spelling-error %description -l en_US repos -> ropes, reps, repose python-gertty.src: W: spelling-error %description -l en_US repo -> rope, rep, reps 2 packages and 0 specfiles checked; 0 errors, 8 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0 upstream tarball: 8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0 + License is "ASL 2.0 " and included in its own text file. Suggestions: 1) Fix rpmlint warning wrong-file-end-of-line-encoding 2) In spec at one line you have %{python_sitelib}/%{pypi_name} should be %{python2_sitelib}/%{pypi_name} 3) you can use %{_prefix}/share/%{pypi_name}/examples/* as %{_datadir}/%{pypi_name}/examples/*
(In reply to Parag AN(पराग) from comment #2) > Review: > > + Package built successful in mock (f22 x86_64) > > - rpmlint on generated rpms gave output > python-gertty.noarch: W: spelling-error %description -l en_US workflow -> > work flow, work-flow, workforce > python-gertty.noarch: W: spelling-error %description -l en_US repos -> > ropes, reps, repose > python-gertty.noarch: W: spelling-error %description -l en_US repo -> rope, > rep, reps > python-gertty.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/python-gertty/LICENSE > python-gertty.noarch: W: no-manual-page-for-binary gertty > python-gertty.src: W: spelling-error %description -l en_US workflow -> work > flow, work-flow, workforce > python-gertty.src: W: spelling-error %description -l en_US repos -> ropes, > reps, repose > python-gertty.src: W: spelling-error %description -l en_US repo -> rope, > rep, reps > 2 packages and 0 specfiles checked; 0 errors, 8 warnings. > > + Source verified with upstream as (sha256sum) > srpm tarball: > 8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0 > upstream tarball: > 8d731c6bd20bdd4ac0f0040338773e1292dee0e54f1089b150d05f0e358acfc0 > > + License is "ASL 2.0 " and included in its own text file. > > > Suggestions: > 1) Fix rpmlint warning wrong-file-end-of-line-encoding Fixed by having this in %setup section: sed -i 's/\r$//' <file_to_strip> Result: $ rpmlint python-gertty.spec /home/kashyap/rpmbuild/RPMS/noarch/python-gertty-1.0.3-2.fc20.noarch.rpm python-gertty.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce python-gertty.noarch: W: spelling-error %description -l en_US repos -> ropes, reps, repose python-gertty.noarch: W: spelling-error %description -l en_US repo -> rope, rep, reps python-gertty.noarch: W: no-manual-page-for-binary gertty 1 packages and 1 specfiles checked; 0 errors, 4 warnings. > > 2) In spec at one line you have > %{python_sitelib}/%{pypi_name} > should be > %{python2_sitelib}/%{pypi_name} Fixed. > > 3) you can use > %{_prefix}/share/%{pypi_name}/examples/* > as > %{_datadir}/%{pypi_name}/examples/* Fixed. Thank you for the review. Updated SPEC and SRPM: SPEC: https://kashyapc.fedorapeople.org/spec-files/python-gertty.spec SRPM: https://kashyapc.fedorapeople.org/srpms/python-gertty-1.0.3-2.fc20.src.rpm * Wed Nov 19 2014 Kashyap Chamarthy <kashyapc> - 1.0.3-2 - Fix rpmlint warnings (wrong-file-end-of-line-encoding) - Fix and simplify RPM macros
SPEC Looks good. APPROVED.
New Package SCM Request ======================= Package Name: python-gertty Short Description: Gertty is a console-based interface to the Gerrit Code Review system Upstream URL: https://pypi.python.org/pypi/gertty Owners: kashyapc Branches: f21 f22
Git done (by process-git-requests).
python-gertty-1.0.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-gertty-1.0.3-2.fc21
python-gertty-1.0.3-2.fc21 has been pushed to the Fedora 21 testing repository.
python-gertty-1.0.3-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-gertty-1.0.3-3.fc21
python-gertty-1.0.3-3.fc21 has been pushed to the Fedora 21 stable repository.