Bug 1165827 - Remove bashism from configure.ac
Summary: Remove bashism from configure.ac
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-19 19:03 UTC by Alexander Tsoy
Modified: 2014-11-19 19:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-19 19:16:05 UTC
Embargoed:


Attachments (Terms of Use)

Description Alexander Tsoy 2014-11-19 19:03:34 UTC
Please remove bashism from configure.ac:

- if test "x$with_firewalld" == "xyes" ; then
+ if test "x$with_firewalld" = "xyes" ; then


configure gives the following warning with dash:

...
checking for GNUTLS... yes
checking for gnutls/crypto.h... yes
checking for pkcheck... /usr/bin/pkcheck
checking whether pkcheck supports uid value... yes
./configure: 63906: test: xno: unexpected operator
checking for dtrace... no
checking for mntent.h... (cached) yes
checking for mount... /bin/mount
...

Comment 1 Eric Blake 2014-11-19 19:11:55 UTC
For issues like this, it's faster to just post your patch directly upstream to libvir-list. But I can take care of it...

Comment 2 Eric Blake 2014-11-19 19:16:05 UTC
commit aca0ae1faa163bbd60ee8df4b93ae870aa820746
Author: Eric Blake <eblake>
Date:   Wed Nov 19 12:13:14 2014 -0700

    maint: use portable shell
    
    Reported in https://bugzilla.redhat.com/show_bug.cgi?id=1165827;
    dash complains:
    
    checking for pkcheck... /usr/bin/pkcheck
    checking whether pkcheck supports uid value... yes
    ./configure: 63906: test: xno: unexpected operator
    checking for dtrace... no
    
    * configure.ac: Use '=' not '==' in test.
    
    Signed-off-by: Eric Blake <eblake>


Note You need to log in before you can comment on or make changes to this bug.