Bug 1169115 - Review Request: nodejs-console-browserify - Emulate console for all the browsers
Summary: Review Request: nodejs-console-browserify - Emulate console for all the browsers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1169113
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-30 13:10 UTC by Piotr Popieluch
Modified: 2014-12-28 20:42 UTC (History)
2 users (show)

Fixed In Version: nodejs-console-browserify-1.1.0-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-14 12:43:20 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-11-30 13:10:00 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-console-browserify.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-console-browserify-1.1.0-1.fc21.src.rpm
Description: Emulate console for all the browsers
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-06 17:20:36 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-console-browserify.noarch: W: only-non-binary-in-usr-lib
nodejs-console-browserify.noarch: W: dangling-symlink /usr/lib/node_modules/console-browserify/node_modules/date-now /usr/lib/node_modules/date-now
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: ddec38650f2e8222cf11cd606b049deac50d04712c88d061decd4de650a3cb49
upstream tarball:  ddec38650f2e8222cf11cd606b049deac50d04712c88d061decd4de650a3cb49

+ License is "MIT" and included in its own LICENCE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed

APPROVED.

Comment 2 Piotr Popieluch 2014-12-06 17:29:19 UTC
New Package SCM Request
=======================
Package Name: nodejs-console-browserify
Short Description: Emulate console for all the browsers
Upstream URL: https://github.com/Raynos/console-browserify
Owners: piotrp
Branches: f19 f20 f21 el6 epel7
InitialCC: piotrp

Comment 3 Gwyn Ciesla 2014-12-08 14:07:02 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2014-12-11 08:08:23 UTC
nodejs-console-browserify-1.1.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-console-browserify-1.1.0-1.fc21

Comment 5 Fedora Update System 2014-12-11 08:08:46 UTC
nodejs-console-browserify-1.1.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-console-browserify-1.1.0-1.fc20

Comment 6 Fedora Update System 2014-12-11 08:09:27 UTC
nodejs-console-browserify-1.1.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-console-browserify-1.1.0-1.fc19

Comment 7 Fedora Update System 2014-12-11 08:09:46 UTC
nodejs-console-browserify-1.1.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-console-browserify-1.1.0-1.el7

Comment 8 Fedora Update System 2014-12-12 23:08:36 UTC
nodejs-console-browserify-1.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 9 Piotr Popieluch 2014-12-14 12:43:20 UTC
Package built and in testing, closing bug.

Comment 10 Fedora Update System 2014-12-21 06:36:44 UTC
nodejs-console-browserify-1.1.0-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 11 Fedora Update System 2014-12-21 06:38:48 UTC
nodejs-console-browserify-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 12 Fedora Update System 2014-12-21 06:39:18 UTC
nodejs-console-browserify-1.1.0-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 13 Fedora Update System 2014-12-28 20:42:45 UTC
nodejs-console-browserify-1.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.