Bug 1176725 - backport features and fixes from webassets 0.10
Summary: backport features and fixes from webassets 0.10
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: python-webassets
Version: epel7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-22 23:50 UTC by Dan Callaghan
Modified: 2015-01-07 19:31 UTC (History)
3 users (show)

Fixed In Version: python-webassets-0.9-5.el7
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-07 19:31:35 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2014-12-22 23:50:04 UTC
webassets 0.10 is in F21 and rawhide, but it has some fundamental API changes which makes it unsuitable for F20 and EPEL7 stable branches which have 0.9 currently.

To ease compatibility issues for dependent packages (such as flask-assets: https://bugzilla.redhat.com/show_bug.cgi?id=1163974#c6) it would be useful to backport as many API-compatible fixes and enhancements from 0.10 as possible.

I reviewed the complete git history of 0.9..0.10 and I think the following commits are suitable for backporting. Some of these are already applied in the package in one form or another.

Escape JS string literals correctly in JST filter (already applied)
https://github.com/miracle2k/webassets/commit/fad3aded6837751f68b6f3af6851ef19c64dd04c

Fix for external tools such as r.js which move output file into place
https://github.com/miracle2k/webassets/commit/5a4fe0f01ca9fba96ae40a3df2a62b43aedd48b4
https://github.com/miracle2k/webassets/commit/3d0e299202366a035ba2e7b6a51b17fc6b7c6482

Fix encoding issues with non-ASCII files (different but equivalent patch was already applied)
https://github.com/miracle2k/webassets/commit/cd072974dad06f4000987226485b285d6647f31c
https://github.com/miracle2k/webassets/commit/d8349be9dff5089d8105920b9fbc647ef9cc2eb3
plus test fixes from
https://github.com/miracle2k/webassets/commit/314b93652363e2992c40d27f1f8e07d6fd0c709f

Avoid an extra stat() call on cache lookups (already applied)
https://github.com/miracle2k/webassets/commit/48c132bff387056ab311e40db6ba6bae51d95277

Fix multiple writing processes with FilesystemCache (already applied)
https://github.com/miracle2k/webassets/commit/18ffd83655f11898d4f7f52e9ed47e892a6955b9

Support files lists or tuples in Jinja2 assets block
https://github.com/miracle2k/webassets/commit/2c2851f3049966e6738a07a06deeb544cb12aca0

Fix cssrewrite filter dealing with hostnames
https://github.com/miracle2k/webassets/commit/7d76ec6f729e86d2ad71e1b8e0b70a72a66e8621

Return proper exit status from webassets command
https://github.com/miracle2k/webassets/commit/17438b922f957bff370478075798b566c7d71612

jinja_ext parameter for Jinja2Loader (this is needed by flask-assets 0.10)
https://github.com/miracle2k/webassets/commit/c8873e0027156807e1f4d1eea7c10e3760a50bb2

Fix expected outputs in tests for latest versions of tools
https://github.com/miracle2k/webassets/commit/1abd59b284ceb2bfc1b83768a19b9e8e94d6a268

Fix closing temporary files
https://github.com/miracle2k/webassets/commit/3ca7a31fa01766c2f0ae2fac1ef974ea2c0e08e0

While I was working on this I also discovered that webassets doesn't work properly with the jsmin.py module from v8 which is shipped in Fedora. Its API is different to the various other python jsmin modules floating around. I submitted a pull request to fix that.

https://github.com/miracle2k/webassets/pull/372

Comment 1 Dan Callaghan 2014-12-22 23:51:10 UTC
I created an 0.9-stable branch in my Github fork, with these commits cherry-picked.

https://github.com/danc86/webassets/commits/0.9-stable

Comment 2 Fedora Update System 2014-12-23 00:02:53 UTC
python-webassets-0.9-5.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-webassets-0.9-5.el7

Comment 3 Fedora Update System 2014-12-23 00:23:14 UTC
python-webassets-0.9-5.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-webassets-0.9-5.fc20

Comment 4 Fedora Update System 2014-12-23 08:03:07 UTC
Package python-webassets-0.9-5.el7:
* should fix your issue,
* was pushed to the Fedora EPEL 7 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing python-webassets-0.9-5.el7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-4840/python-webassets-0.9-5.el7
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2015-01-06 06:11:54 UTC
python-webassets-0.9-5.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2015-01-07 19:31:35 UTC
python-webassets-0.9-5.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.