Spec URL: http://declera.com/~yaneti/perl-Algorithm-Combinatorics/perl-Algorithm-Combinatorics.spec SRPM URL: http://declera.com/~yaneti/perl-Algorithm-Combinatorics/perl-Algorithm-Combinatorics-0.27-1.fc22.src.rpm Description: Algorithm::Combinatorics is an efficient generator of combinatorial sequences. Algorithms are selected from the literature (work in progress, see "REFERENCES"). Iterators do not use recursion, nor stacks, and are written in C. Fedora Account System Username: yaneti perl-Algorithm-Combinatorics.src: W: spelling-error Summary(en_US) combinatorial -> combination perl-Algorithm-Combinatorics.src: W: spelling-error %description -l en_US combinatorial -> combination perl-Algorithm-Combinatorics.x86_64: W: spelling-error Summary(en_US) combinatorial -> combination perl-Algorithm-Combinatorics.x86_64: W: spelling-error %description -l en_US combinatorial -> combination perl-Algorithm-Combinatorics-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package perl-Algorithm-Combinatorics. 3 packages and 0 specfiles checked; 1 errors, 4 warnings. This package sits under some of the RDF cpan hierarchy (RDF::Trine). Its not updated frequently, so although I am decidedly not knowledgeable about combinatorics I think I can handle it as package in Fedora.
Missing BRs: - perl, called in the SPEC - perl(base), Combinatorics.pm:14 - perl(Carp), Combinatorics.pm:11 - perl(Exporter), Combinatorics.pm:13-14 - perl(FindBin), t/* - perl(lib), t/* - perl(strict), Makefile.PL:1, Combinatorics.pm:4, t/* - perl(warnings), Makefile.PL:2, t/* - perl(XSLoader), Combinatorics.pm:8 Test::More is only used at build-time; there's no point in requiring it at runtime. Scalar::Util will be autodetected by rpmbuild; no need to require it explicitly. The following line is unnecessary: find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; The %description points to a section in POD which isn't available in the RPM metadata. Remove that note. Consider using DESTDIR instead of PERL_INSTALL_ROOT. If you're building only for F21+, you can raise the minimum EU::MM requirement to 6.76 and utilize the NO_PACKLIST feature; this would save you another line in %install. Consider packaging the benchmarks in %doc; the distribution POD mentions them.
Thanks for the review. I think I addressed all of your remarks in -2. F21 only so followed your EU::MM recommendation. Spec URL: http://declera.com/~yaneti/perl-Algorithm-Combinatorics/perl-Algorithm-Combinatorics.spec SRPM URL: http://declera.com/~yaneti/perl-Algorithm-Combinatorics/perl-Algorithm-Combinatorics-0.27-2.fc22.src.rpm - 0.27-2 - Fixes according to review feedback (#1179233)
Ack, all addressed :) Approving.
New Package SCM Request ======================= Package Name: perl-Algorithm-Combinatorics Short Description: Efficient generation of combinatorial sequences Owners: yaneti Branches: f21 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Algorithm-Combinatorics-0.27-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Algorithm-Combinatorics-0.27-2.fc21
perl-Algorithm-Combinatorics-0.27-2.fc21 has been pushed to the Fedora 21 testing repository.
perl-Algorithm-Combinatorics-0.27-2.fc21 has been pushed to the Fedora 21 stable repository.