Description of problem: When reviewing a package I found some confusing output in the review template (review.txt). A) The Issues section contains: - POM files have correct Maven mapping Note: Old style Maven package found, no add_maven_depmap calls found but POM files present See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro The referenced link is not correct. The page https://fedoraproject.org/wiki/Packaging:Java exists, but there is no anchor named add_maven_depmap_macro on that page. It is not clear what the note is trying to say. The guidelines say "Additionally package MUST install mapping between upstream artifact and filesystem by using either %mvn_install or %add_maven_depmap macros." (https://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files) and the package installs the pom file using %mvn_install (after using %mvn_artifact), so why complain about no %add_maven_depmap when either method is in accordance with the guidelines? B) The Issues section also contains: - Packages have proper BuildRequires/Requires on jpackage-utils It is not clear why this is listed in issues. Proper BuildRequires according to the guidelines is one of java-devel, maven-local or ant. Either of them directly or indirectly depends on jpackage-utils and the requirement to explicitly list jpackage-utils in BuildRequires have been dropped from the guidelines. The dependency on jpackage-utils for the generated binary packages is autogenerated by dependency generator and should not be listed explicitly either. C) Must items - Generic section contains: [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. Why the "' '" after install? D) Rpmlint (installed packages) ]0;<mock-chroot><mock-chroot>[root@ellert /]# rpmlint irclib irclib-javadoc 2 packages and 0 specfiles checked; 0 errors, 0 warnings. ]0;<mock-chroot><mock-chroot>[root@ellert /]# echo 'rpmlint-done:' A lot of junk here... Version-Release number of selected component (if applicable): fedora-review-0.5.2-1.fc21.noarch How reproducible: Always (well, at least twice). Steps to Reproduce: 1. fedora-review -b 976049 -m fedora-rawhide-x86_64 Actual results: See above. Expected results: None of that.
I have inspected C) in the current sources. For now assuming that this is fixed. D) is partially fixed in https://fedorahosted.org/FedoraReview/changeset/f1ae1243d0d20bbc. Some junk including the '# echo 'rpmlint-done:' line will still be there, the code isnt that clever. Lazy programmmer... As for A) and B) these are about the java plugin which is maintained separately in the fedora-review-plugin-java package. However, bugzilla doesn't let me re-assign to it :(
See also upstream bug https://fedorahosted.org/FedoraReview/ticket/240.
Assigning to Stanislaw in his capacity as the java plugin maintainer (cannot re-assign bug to proper component for some reason
Well the java tests are part of javapackages-tools in a subpackage so reassigning
Thanks for reporting this. We'll look into updating fedora-review Java plugin to latest standards.
Both A and B should be fixed upstream, I'll backport the fixes to f21
fedora-review-plugin-java-4.6.1-1.fc22,javapackages-tools-4.3.2-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/fedora-review-plugin-java-4.6.1-1.fc22,javapackages-tools-4.3.2-6.fc22
fedora-review-plugin-java-4.6.1-1.fc21,javapackages-tools-4.1.0-8.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/fedora-review-plugin-java-4.6.1-1.fc21,javapackages-tools-4.1.0-8.fc21
fedora-review-plugin-java-4.6.1-1.fc20,javapackages-tools-3.4.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fedora-review-plugin-java-4.6.1-1.fc20,javapackages-tools-3.4.1-3.fc20
Package javapackages-tools-4.3.2-6.fc22, fedora-review-plugin-java-4.6.1-1.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing javapackages-tools-4.3.2-6.fc22 fedora-review-plugin-java-4.6.1-1.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-6779/fedora-review-plugin-java-4.6.1-1.fc22,javapackages-tools-4.3.2-6.fc22 then log in and leave karma (feedback).
javapackages-tools-4.3.2-6.fc22, fedora-review-plugin-java-4.6.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
javapackages-tools-3.4.1-3.fc20, fedora-review-plugin-java-4.6.1-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
javapackages-tools-4.1.0-8.fc21, fedora-review-plugin-java-4.6.1-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.