Bug 1191981 - xdg-open wrongly passes all command line arguments as one argument to e.g. okular on non Gnome desktops
Summary: xdg-open wrongly passes all command line arguments as one argument to e.g. ok...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xdg-utils
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-12 10:43 UTC by Till Maas
Modified: 2015-02-25 13:28 UTC (History)
2 users (show)

Fixed In Version: xdg-utils-1.1.0-0.38.rc3.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-25 13:28:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
FreeDesktop.org 89130 0 None None None Never

Description Till Maas 2015-02-12 10:43:12 UTC
Description of problem:
xdg-open /path/to/foo.pdf on i3 with xdg-open configured to use okular to open PDF documents calls

/usr/bin/okular '/path/to/foo.pdf --icon okular -caption Okular' instead of

/usr/bin/okular /path/to/foo.pdf --icon okular -caption Okular

Version-Release number of selected component (if applicable):
xdg-utils-1.1.0-0.35.rc3.fc21

Additional info:
This is probably a regression of the fix of the command injection.

Btw. would it be ok to re-implement xdg-open it in python? Shell does not really seem to be the proper language for this.

Comment 1 Rex Dieter 2015-02-12 12:56:45 UTC
I regret allowing in those generic methods, one *really* should just depend on gvfs-open (or kde-open) instead.

In the meantime, I'll try to find some time to revisit fixing argument passing.

And no, python isn't a viable option (not in any foreseable future)

Comment 2 Rex Dieter 2015-02-20 21:34:07 UTC
this should get fixed working on upstream,
https://bugs.freedesktop.org/show_bug.cgi?id=89130

Comment 3 Fedora Update System 2015-02-20 22:12:12 UTC
xdg-utils-1.1.0-0.37.rc3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/xdg-utils-1.1.0-0.37.rc3.fc21

Comment 4 Fedora Update System 2015-02-22 06:03:50 UTC
Package xdg-utils-1.1.0-0.38.rc3.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xdg-utils-1.1.0-0.38.rc3.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2401/xdg-utils-1.1.0-0.38.rc3.fc21
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2015-02-25 13:28:13 UTC
xdg-utils-1.1.0-0.38.rc3.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.