Bug 1195364 - thrift-0.9.1-13.fc23.3 FTBFS: thrift-0.9.1/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:29: error: package javax.servlet does not exist
Summary: thrift-0.9.1-13.fc23.3 FTBFS: thrift-0.9.1/lib/java/src/org/apache/thrift/ser...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: thrift
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Srb
QA Contact: Fedora Extras Quality Assurance
URL: http://koji.fedoraproject.org/koji/ta...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-23 16:19 UTC by Petr Pisar
Modified: 2015-04-24 15:54 UTC (History)
3 users (show)

Fixed In Version: thrift-0.9.1-16.fc23
Clone Of:
Environment:
Last Closed: 2015-04-24 15:54:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2015-02-23 16:19:44 UTC
thrift-0.9.1-13.fc23.3 fails to build in F23:

make[3]: Entering directory '/builddir/build/BUILD/thrift-0.9.1/lib/java'
/usr/bin/ant 
Buildfile: /builddir/build/BUILD/thrift-0.9.1/lib/java/build.xml
setup.init:
    [mkdir] Created dir: /builddir/build/BUILD/thrift-0.9.1/lib/java/build
    [mkdir] Created dir: /builddir/build/BUILD/thrift-0.9.1/lib/java/build/lib
    [mkdir] Created dir: /builddir/build/BUILD/thrift-0.9.1/lib/java/build/tools
    [mkdir] Created dir: /builddir/build/BUILD/thrift-0.9.1/lib/java/build/test
init:
compile:
    [javac] Compiling 100 source files to /builddir/build/BUILD/thrift-0.9.1/lib/java/build
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
    [javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] target value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] /builddir/build/BUILD/thrift-0.9.1/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:29: error: package javax.servlet does not exist
    [javac] import javax.servlet.ServletConfig;
    [javac]                     ^

Difference between working and failing build root is:

        tomcat-servlet-3.1-api 		> 	8.0.18-1.fc23
	tomcat-servlet-3.0-api 	7.0.54-3.fc21 	<

Comment 1 gil cattaneo 2015-04-21 18:05:46 UTC
sorry for the noise but 
you could change 
tomcat-servlet-3.0-api in tomcat-servlet-3.1-api (or use glassfish-servlet-api.jar 3.1 apis)
and correct the patch which use the old servlet-3.0-api references
e.g.
thrift-0.9.1-buildxml.patch

+++ b/lib/java/build.xml

+      <include name="slf4j/api.jar"/>
-+      <include name="tomcat-servlet-3.0-api.jar"/>
++      <include name="glassfish-servlet-api.jar"/>

tutorial/java/build.xml

+      <include name="slf4j/api.jar"/>
-+      <include name="tomcat-servlet-3.0-api.jar"/>
++      <include name="glassfish-servlet-api.jar"/>
     </fileset>
   </path>
   <path id="build.classpath">

+      <include name="slf4j/api.jar"/>
-+      <include name="tomcat-servlet-3.0-api.jar"/>
++      <include name="glassfish-servlet-api.jar"/>
+    </fileset>
   </path>
   <path id="tutorial.classpath">
     <path refid="build.classpath" />

+++ b/tutorial/js/build.xml

+      <include name="slf4j/api.jar"/>
-+      <include name="tomcat-servlet-3.0-api.jar"/>
++      <include name="glassfish-servlet-api.jar"/>


fb303-0.9.1-buildxml.patch

+++ b/contrib/fb303/java/build.xml
+	  <include name="slf4j/api.jar"/>
-+      <include name="tomcat-servlet-3.0-api.jar"/>
++      <include name="glassfish-servlet-api.jar"/>


if there are no problems (but i doubt it) should build
otherwise post the build.log

Comment 2 Michal Srb 2015-04-24 15:54:08 UTC
Fixed, closing.


Note You need to log in before you can comment on or make changes to this bug.