RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
When adding two entries for custom modes in the Windows QXL driver, the mode id's could be set to values that duplicate existing modes.

Version-Release number of selected component (if applicable):
3.6

How reproducible:
Always

Steps to Reproduce:
1. In the Windows QXL driver, when appending 2 entries to hold the custom resolution, the id's are set to the index values of the entries.  But because the mode id's the list may not be consecutive (though always increasing), the index may be less that the maximum mode id passed from QEMU. The could lead to the custom id's duplicating id already in the list. 
2.
3.

Actual results:


Expected results:


Additional info:

Assigned to the qxl driver

Assigned to the qxl driver

Sandy, is the bug stuck on MODIFIED? Where and when is the code available for testing?

(In reply to Yaniv Kaul from comment #4)
> Sandy, is the bug stuck on MODIFIED? Where and when is the code available
> for testing?

QA ack is missing, and we are still working on the driver

In the meantime the updated code is here, http://git.app.eng.bos.redhat.com/git/spice/win/qxl.git/

I found this stepping through the code and via an actual bug.  So the change is more a safe guard against it happening in the future.  I didn't find a good way to test it other than stepping through the code.

moving from RHEVM product to RHEL 8