Bug 1203898 - Support inspecting docker images without /etc/fstab
Summary: Support inspecting docker images without /etc/fstab
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-19 21:52 UTC by Colin Walters
Modified: 2016-05-10 16:42 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-10 16:42:47 UTC
Embargoed:


Attachments (Terms of Use)

Description Colin Walters 2015-03-19 21:52:04 UTC
See: https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?id=f2ad1bb926c5ef6eaa5f60bf66c39e4a716cb953

We want to not ship an /etc/fstab in docker images because docker has nothing to do with partition tables and filesystems; we're just reusing the same infrastructure to generate them (Anaconda) that's used for virt and bare metal.

Removing it in %post doesn't work because libguestfs currently needs it.  Since we control the entire toolchain here, one option I see is to explicitly tell oz to tell libguestfs to look on the first partition only for example.

Alternatively, libguestfs could assume a filesystem with no /etc/fstab but that does have /usr/lib/os-release (or /etc/os-release) is an OS disk.

Comment 1 Richard W.M. Jones 2015-03-20 08:40:55 UTC
We should be able to deal with the no fstab case.

See also:
https://bugzilla.redhat.com/show_bug.cgi?id=1113153

Comment 2 Colin Walters 2015-03-20 13:32:45 UTC
Or alternatively, we teach imagefactory how to extract ICICLE from the tarball.  Then all we need from libguestfs is the tar_out_opts() API call.

Comment 3 Jan Kurik 2015-07-15 14:23:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 4 Pino Toscano 2016-05-10 16:42:47 UTC
Fixed with
https://github.com/libguestfs/libguestfs/commit/f3c278474db0eb7648901094eee7b838d141e018
which is in libguestfs 1.33.28.


Note You need to log in before you can comment on or make changes to this bug.