Bug 1204136 - Review Request: perl-Package-New - Simple base package from which to inherit
Summary: Review Request: perl-Package-New - Simple base package from which to inherit
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-20 13:09 UTC by Tom "spot" Callaway
Modified: 2015-03-20 19:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-20 19:28:21 UTC
Type: ---
emmanuel: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2015-03-20 13:09:42 UTC
Spec URL: https://spot.fedorapeople.org/perl-Package-New.spec
SRPM URL: https://spot.fedorapeople.org/perl-Package-New-0.07-1.fc21.src.rpm
Description: The Package::New object provides a consistent object constructor for
objects.
Fedora Account System Username: spot
Koji Rawhide Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9279601

This simple little perl package is needed to update perl-Geo-Forward.

Comment 1 Emmanuel Seyman 2015-03-20 13:21:14 UTC
Taking.

Comment 2 Emmanuel Seyman 2015-03-20 14:28:20 UTC
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=9279601

 [x] Rpmlint output:
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
None specifed, default is used.

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: BSD
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %license.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
00805fd07f1c330b71b2e3d120a6ad55  Package-New-0.07.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=9279601
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=3, Tests=29,  0 wallclock secs ( 0.10 usr  0.00 sys +  0.27 cusr  0.04 csys =  0.41 CPU)
Result: PASS

Note that the spec file could be improved:

- s/PERL_INSTALL_ROOT/DESTDIR/
- NO_PACKLIST=1 could be added to Makefile.PL arguments (the .packlist line could then be removed
- the rmdir is not necessary

None of these are blockers, so APPROVED.

Comment 3 Tom "spot" Callaway 2015-03-20 18:44:08 UTC
New Package SCM Request
=======================
Package Name: perl-Package-New
Short Description: Simple base package from which to inherit
Upstream URL: http://search.cpan.org/dist/Package-New/
Owners: spot
Branches: f20 f21 f22
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2015-03-20 18:48:40 UTC
Git done (by process-git-requests).

Comment 5 Tom "spot" Callaway 2015-03-20 19:28:21 UTC
In rawhide. Updates coming.


Note You need to log in before you can comment on or make changes to this bug.