Spec URL: https://kalev.fedorapeople.org/mingw-libepoxy.spec SRPM URL: https://kalev.fedorapeople.org/mingw-libepoxy-1.2-1.fc22.src.rpm Description: Epoxy is a library for handling OpenGL function pointer management. This package contains the MinGW Windows cross compiled libepoxy library. Fedora Account System Username: kalev
Taking for review * Is there a particular reason why you're running 'autoreconf'? There are no patches bundled which require the auto* tools to be executed * Please use a versioned BR: mingw{32,64}-filesystem (for example >= 95) * The BR: mingw{32,64}-binutils is redundant and can be dropped
(In reply to Erik van Pienbroek from comment #1) > Taking for review > > * Is there a particular reason why you're running 'autoreconf'? There are no > patches bundled which require the auto* tools to be executed Yes -- the upstream tarball is without a configure script. Need to generate it first to be able to build anything. > * Please use a versioned BR: mingw{32,64}-filesystem (for example >= 95) Why? We don't have anything older in any supported Fedora releases anyway.
I noticed myself that I'd put wrong license tag in the spec file. Here are updated files: * Tue Mar 24 2015 Kalev Lember <kalevlember> - 1.2-2 - Package review fixes (#1205194) - Don't explicitly BR mingw{32,64}-binutils - Fix the license tag Spec URL: https://kalev.fedorapeople.org/mingw-libepoxy.spec SRPM URL: https://kalev.fedorapeople.org/mingw-libepoxy-1.2-2.fc22.src.rpm
(In reply to Kalev Lember from comment #2) > (In reply to Erik van Pienbroek from comment #1) > > * Please use a versioned BR: mingw{32,64}-filesystem (for example >= 95) > > Why? We don't have anything older in any supported Fedora releases anyway. It is part of the current MinGW packages guidelines @ https://fedoraproject.org/wiki/Packaging:MinGW#Dependencies But I agree with you that it is a bit redundant these days as all current Fedora and EPEL releases provide mingw-filesystem 95 or higher. Sounds like something we should fix whenever we update our packaging guidelines again. For now you can leave it 'as is'
$ rpmlint mingw-libepoxy.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-libepoxy-1.2-2.fc22.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-libepoxy-1.2-2.fc22.noarch.rpm mingw64-libepoxy-1.2-2.fc22.noarch.rpm mingw32-libepoxy.noarch: W: no-documentation mingw64-libepoxy.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpm --query --requires mingw32-libepoxy mingw32(kernel32.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem >= 95 mingw32-pkg-config rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-libepoxy mingw64(kernel32.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem >= 95 mingw64-pkg-config rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-libepoxy mingw32(libepoxy-0.dll) mingw32-libepoxy = 1.2-2.fc22 $ rpm --query --provides mingw64-libepoxy mingw64(libepoxy-0.dll) mingw64-libepoxy = 1.2-2.fc22 $ wget --quiet https://github.com/anholt/libepoxy/archive/v1.2/libepoxy-1.2.tar.gz -O - | md5sum 12d6b7621f086c0c928887c27d90bc30 - $ md5sum libepoxy-1.2.tar.gz 12d6b7621f086c0c928887c27d90bc30 libepoxy-1.2.tar.gz + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal The rpmlint warning can be avoided by adding %doc README.md to both subpackages but this is a minor issue ====================================================== The package mingw-libepoxy is APPROVED by epienbro ======================================================
Thanks for the quick review, Erik! New Package SCM Request ======================= Package Name: mingw-libepoxy Short Description: MinGW Windows libepoxy library Upstream URL: https://github.com/anholt/libepoxy Owners: kalev epienbro Branches: f22 InitialCC:
Git done (by process-git-requests).
Package imported and built.