Bug 1207704 - Review Request: perl-mixin - Mixin inheritance, an alternative to multiple inheritance
Summary: Review Request: perl-mixin - Mixin inheritance, an alternative to multiple in...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-31 13:56 UTC by Petr Šabata
Modified: 2015-05-14 09:01 UTC (History)
2 users (show)

Fixed In Version: perl-mixin-0.07-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 09:01:43 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
puiterwijk: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2015-03-31 13:56:12 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-mixin/perl-mixin.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-mixin/perl-mixin-0.07-1.fc21.src.rpm
Description:
Mixin inheritance is an alternative to the usual multiple-inheritance and
solves the problem of knowing which parent will be called. It also solves a
number of tricky problems like diamond inheritance.
Fedora Account System Username: psabata

Comment 1 Jitka Plesnikova 2015-04-02 13:49:45 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-mixin-0.07-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(Carp)
      1 perl(base)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-mixin-0.07-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(mixin) = 0.07
      1 perl(mixin::with) = 0.07
      1 perl-mixin = 0.07-1.fc23
Binary provides are Ok.

$ rpmlint perl-mixin*
perl-mixin.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-mixin/LICENSE
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
Incorrect address was reported to upstream.
Rpmlint is ok


Package is good.
APPROVED.

Comment 2 Petr Šabata 2015-04-02 14:10:04 UTC
New Package SCM Request
=======================
Package Name: perl-mixin
Short Description: Mixin inheritance, an alternative to multiple inheritance
Upstream URL: http://search.cpan.org/dist/mixin/
Owners: psabata jplesnik ppisar
Branches: f22 f21
InitialCC: perl-sig

Comment 3 Patrick Uiterwijk 2015-04-02 14:48:12 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2015-04-02 15:35:24 UTC
perl-mixin-0.07-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/perl-mixin-0.07-1.fc22

Comment 5 Fedora Update System 2015-04-02 15:35:40 UTC
perl-mixin-0.07-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-mixin-0.07-1.fc21

Comment 6 Petr Šabata 2015-04-02 15:49:52 UTC
Thank you both.

Comment 7 Fedora Update System 2015-04-18 09:49:01 UTC
perl-mixin-0.07-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 8 Fedora Update System 2015-04-21 18:43:36 UTC
perl-mixin-0.07-1.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.