Bug 1208830 - Re-Review Request: gdouros-aegean-fonts - A font for ancient scripts in the greater Aegean vicinity
Summary: Re-Review Request: gdouros-aegean-fonts - A font for ancient scripts in the g...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-03 10:57 UTC by Alexander Ploumistos
Modified: 2015-05-08 07:32 UTC (History)
2 users (show)

Fixed In Version: gdouros-aegean-fonts-7.45-0.2.20150430.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-08 07:32:26 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 529323 0 low CLOSED Review Request: gdouros-aegean-fonts - Font for ancient scripts in the Aegean vicinity 2021-02-22 00:41:40 UTC

Internal Links: 529323

Description Alexander Ploumistos 2015-04-03 10:57:36 UTC
Spec URL:
https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegean-fonts/gdouros-aegean-fonts.spec

SRPM URL:
https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-aegean-fonts/gdouros-aegean-fonts-7.45-1.fc21.src.rpm

Description:
Aegean covers the following scripts and symbols: Basic Latin, Greek and Coptic,
Greek Extended, some Punctuation and other Symbols, Linear B Syllabary, Linear
B Ideograms, Aegean Numbers, Ancient Greek Numbers, Ancient Symbols, Phaistos
Disc, Lycian, Carian, Old Italic, Ugaritic, Old Persian, Cypriot Syllabary,
Phoenician, Lydian, Archaic Greek Musical Notation, Cretan Hieroglyphs,
Cypro-Minoan, Linear A, the Arkalochori Axe, Ancient Greek and Old Italic
variant alphabets. Those of the above that are not supported by the Unicode
Standard 7.0, they are allocated in the Supplementary Private Use Plane 15.

It was created by George Douros.


Fedora Account System Username: alexpl

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9402677


The font is already in fedora, but the current maintainer has been non-responsive for quite some time, so this is the last step of the relevant policy - a takeover request.

I have cleaned up the spec files from deprecated commands, added AppStream metadata and I have included a sample file provided by upstream in a separate doc package. Following a brief discussion on devel ML and after having contacted upstream for clarifications, I have decided not to include the hinted font in the source package.

Comment 2 Parag AN(पराग) 2015-04-30 06:01:06 UTC
Review:

+ mock build is successful for F23 (x86_64)

+ rpmlint on generated rpms gave output
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
 
+ Source verified with upstream as (sha256sum)
srpm Source0: 6053d9714b86933cd74f270b2efd5d03b71ce494b3699f7f7156b02c97aa5e4b
upstream Source0 : 6053d9714b86933cd74f270b2efd5d03b71ce494b3699f7f7156b02c97aa5e4b
srpm Source1 : 0200fde5e69501371ff8404b76e628988088aacda265b533efe38b502231a708
upstream Source1 : 0200fde5e69501371ff8404b76e628988088aacda265b533efe38b502231a708

+ License is "Public Domain" as per given on upstream website "Fonts and documents in this site are not pieces of property or merchandise items; they carry no trademark, copyright, license or other market tags; they are free for any use". So no license text is included in font file or any text file

+ follows fonts packaging guidelines.

+ fontconfig file is present at priority 65.

+ Appdata metainfo file is present.

Looks good. APPROVED.

Comment 3 Parag AN(पराग) 2015-04-30 08:22:04 UTC
I realized while doing review of rh#1208835 that upstream is not consistent in updating font information so its better if we use maximum information in font package name. I propose to follow https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages with following changes

%global checkout 20150430

Release:        0.2.%{checkout}%{?dist}

also add changelog that uses 7.45-0.2.20150430

Comment 5 Parag AN(पराग) 2015-05-02 06:26:38 UTC
The updated srpm in comment#4 looks good now.

Package APPROVED.

You want to submit here package change request to own this package. See https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages

Comment 6 Alexander Ploumistos 2015-05-02 11:27:15 UTC
Package Change Request
======================
Package Name: gdouros-aegean-fonts
Branches: f20 f21 f22 master
Owners: alexpl
InitialCC: fonts-sig

Comment 7 Gwyn Ciesla 2015-05-03 21:35:44 UTC
Complete.

Comment 8 Fedora Update System 2015-05-04 01:28:10 UTC
gdouros-aegean-fonts-7.45-0.2.20150430.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/gdouros-aegean-fonts-7.45-0.2.20150430.fc22

Comment 9 Fedora Update System 2015-05-08 07:32:26 UTC
gdouros-aegean-fonts-7.45-0.2.20150430.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.