Bug 1211176 - Possible to add numa node with pinning to not pinned vm via REST
Summary: Possible to add numa node with pinning to not pinned vm via REST
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.1
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-3.6.1
: 3.6.1
Assignee: Andrej Krejcir
QA Contact: Artyom
URL:
Whiteboard:
Depends On: 1248049
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-13 09:07 UTC by Artyom
Modified: 2016-04-20 01:35 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: a bad check of preferred host list made the AddNumaNodeCommand to fail which made the whole numa configuration disappear. Consequence: can't ping a vm numa node to a vm which doesn't have a pinned host Fix: check if the preferred hot list is not empty, rather than not null Result: UI and REST blocks a creation a of a pinned numa node if the vm isn't pinned to a host (migration isn't allowed)
Clone Of:
Environment:
Last Closed: 2016-04-20 01:35:46 UTC
oVirt Team: SLA
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 46183 0 ovirt-engine-3.5 ABANDONED engine: Fix - AbstractVmNumaNodeCommand checks if VM is pinned Never
oVirt gerrit 46535 0 master MERGED core: Fix detection of preferred hosts for numa nodes Never
oVirt gerrit 47606 0 ovirt-engine-3.6 MERGED core: Fix detection of preferred hosts for numa nodes Never

Description Artyom 2015-04-13 09:07:31 UTC
Description of problem:
Possible to add numa node with pinning to not pinned vm via REST

Version-Release number of selected component (if applicable):
rhevm-3.5.1-0.3.el6ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Update vm(1024 memory, 2 CPU's) via UI under Host tab to:
   Start Running On: some specific host with numa
   Leave migration options: Allow manual or automatic migration
2. Try to add numa pinned node via REST
<vm_numa_node>
    <index>0</index>
    <memory>1024</memory>
    <cpu>
        <cores>
            <core index="0"/>
            <core index="1"/>
        </cores>
    </cpu>
    <numa_node_pins>
        <numa_node_pin pinned="true" index="index_of_host_numa_node">
            <host_numa_node href= "/ovirt-engine/api/hosts/host_id/numanodes/numa_node_id" id="numa_node_id">
            </host_numa_node>
        </numa_node_pin>
    </numa_node_pins>
</vm_numa_node>
3.

Actual results:
Action Success

Expected results:
Action failed, engine must show error message(failed to add pinned numa node, when vm not pinned to host)

Additional info:
Via UI I can not set numa nodes until I pin vm to host(Start Running On: some specific host with numa; Migration options: Do not allow migration)
Bug is also actual for cases when Migration options: Allow manual migration only

Comment 1 Sandro Bonazzola 2015-10-26 12:38:26 UTC
this is an automated message. oVirt 3.6.0 RC3 has been released and GA is targeted to next week, Nov 4th 2015.
Please review this bug and if not a blocker, please postpone to a later release.
All bugs not postponed on GA release will be automatically re-targeted to

- 3.6.1 if severity >= high
- 4.0 if severity < high

Comment 2 Andrej Krejcir 2015-10-29 15:23:16 UTC
The bug is already fixed in 3.6, but can only be seen after Bug 1248049 is fixed.

Comment 3 Artyom 2015-11-29 09:46:05 UTC
Verified on rhevm-restapi-3.6.0.3-0.1.el6.noarch
Failed to add numa node to vm
<fault>
<reason>Operation Failed</reason>
<detail>[Cannot ${action} ${type}. VM must be pinned to a host.]</detail>
</fault>


Note You need to log in before you can comment on or make changes to this bug.