Bug 1218779 - Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands
Summary: Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary co...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tomas Hrcka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-05 20:51 UTC by Neal Gompa
Modified: 2020-05-21 06:13 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-11 08:05:35 UTC
Type: ---
Embargoed:
vondruch: fedora-review?


Attachments (Terms of Use)

Description Neal Gompa 2015-05-05 20:51:13 UTC
Spec URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers.spec

SRPM URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers-0.5.0-1.fc21.src.rpm

Description: 
A Vagrant plugin that allows for the definition of arbitrary
scripts that will run on the host before and/or after Vagrant
commands.

Fedora Account System Username: ngompa

Comment 1 Vít Ondruch 2015-05-06 08:11:54 UTC
Just a few quick notes:

* Empty changelog
  - You should put some entry into changelog

* Unused BuildRequires
  - The following build requires are not required:

    BuildRequires: rubygem-rake, rubygem-rspec, rubygem-simplecov
    BuildRequires: ruby(release)
    BuildRequires: ruby

  - If you put the test suite into usable state, the  rubygem-rspec would be the
    only required gem. Usage of Rake and SimpleCov is discouraged in every case.

* Bundler is not required for runtime
  - I believe that "Requires: rubygem-bundler: is not needed, since
    rubygem-bundler is very likely pulled in via Vagrant dependency.

Comment 2 Vít Ondruch 2015-05-06 08:13:07 UTC
* Too long summary
  - Not sure if there is some limit for Summary, but it seems to be pretty long.

Comment 3 Josef Stribny 2015-05-06 10:16:50 UTC
I will take it for a review.

Please fix first the issues pointed out by Vit.

Comment 4 Neal Gompa 2015-07-05 15:45:10 UTC
New SRPM URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers-0.5.0-2.fc22.src.rpm

Spec URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers.spec

I believe I have addressed everything noted by Vít, except the "usable state test suite" thing. 

While I do now have simplecov disabled, I have continued to have the tests disabled because they throw this error and I don't know how to fix it:

/builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/spec_helper.rb:4:in `require': cannot load such file -- vagrant (LoadError)
	from /builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/spec_helper.rb:4:in `<top (required)>'
	from /builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/vagrant-triggers/action/trigger_spec.rb:1:in `require'
	from /builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/vagrant-triggers/action/trigger_spec.rb:1:in `<top (required)>'
	from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `load'
	from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `block in load_spec_files'
	from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `each'
	from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in `load_spec_files'
	from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/command_line.rb:22:in `run'
	from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:80:in `run'
	from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:17:in `block in autorun'

Comment 6 Vít Ondruch 2016-01-04 09:04:59 UTC
Hi Neal,

what is the status here? Josef takes sabbatical leave, so I should probably finish this.

Comment 7 Neal Gompa 2016-01-04 14:06:17 UTC
Well, my status is basically the same as it was in comment 4, though I suppose I should update to the latest version (0.5.2) and rebase my patches (if needed).

Comment 8 Neal Gompa 2016-01-04 14:14:55 UTC
I've updated to vagrant-triggers 0.5.2.

New SRPM URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers-0.5.2-1.fc23.src.rpm

Spec URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers.spec

Comment 9 Neal Gompa 2016-01-04 14:16:34 UTC
Erk, forgot to note in comment 8 that I still have the same problem as before if I enable tests.

Comment 10 Tomas Hrcka 2016-01-05 12:16:49 UTC
Hi Neal I am taking this review, expect update short time.

Comment 11 Igor Gnatenko 2017-01-01 15:53:56 UTC
ping?

Comment 12 Vít Ondruch 2017-07-27 14:17:02 UTC
(In reply to Neal Gompa from comment #9)
> Erk, forgot to note in comment 8 that I still have the same problem as
> before if I enable tests.

This should help:

~~~
rspec2 -I%{vagrant_dir}/lib spec
~~~

Nevertheless, I don't think this is compatible with Vagrant 1.9+, since this is using Bundler, but Vagrant itself is not using Bundler anymore. I created this [1] PR which might or might not fix the compatibility.

Unfortunately, the upstream is stalled a bit [2].




[1] https://github.com/emyl/vagrant-triggers/pull/90
[2] https://github.com/emyl/vagrant-triggers/issues/85

Comment 13 Aron Griffis 2018-05-10 20:48:59 UTC
Functionality of vagrant-triggers has been merged into vagrant proper now

https://github.com/hashicorp/vagrant/pull/9713

Comment 14 Vít Ondruch 2018-05-11 08:05:35 UTC
(In reply to Aron Griffis from comment #13)
> Functionality of vagrant-triggers has been merged into vagrant proper now
> 
> https://github.com/hashicorp/vagrant/pull/9713

Thx for the info. Because this has not moved forward a lot in past two years, I believe it is save to close this as WONTFIX and focus on update of Vagrant (bug 1574756) instead.


Note You need to log in before you can comment on or make changes to this bug.