Bug 1221637 - [RFE] revert BZ909127 as 'Linux boot options' are not Linux only specific
Summary: [RFE] revert BZ909127 as 'Linux boot options' are not Linux only specific
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: bugs@ovirt.org
QA Contact: Pavel Stehlik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-14 13:16 UTC by Jiri Belka
Modified: 2019-04-28 11:14 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-17 17:10:21 UTC
oVirt Team: Virt
Embargoed:
ylavi: ovirt-future?
ylavi: planning_ack?
ylavi: devel_ack?
ylavi: testing_ack?


Attachments (Terms of Use)

Description Jiri Belka 2015-05-14 13:16:58 UTC
Description of problem:

BZ909127 was wrong, 'Linux boot options' are not Linux only specific. It should support multiboot format.

This format is used for example by syslinux' mboot.c32 module, see example for my pxelinux:

LABEL SmartOS-20150423T155306Z
      MENU INDENT 2
      MENU LABEL SmartOS-20150423T155306Z
      KERNEL mboot.c32
      APPEND smartos/latest/platform/i86pc/kernel/amd64/unix -B smartos=true --- smartos/latest/platform/i86pc/amd64/boot_archive

Thus in theory I could boot a VM with defining mboot.c32 as kernel and now i'm not 100% sure but either initrd or append option and the values above and I could boot what I want.

So this BZ is about to revert the change and rename it based on qemu-kvm --help output:

Linux boot options -> Linux/Multiboot boot options

...and allow this to be defined for all OS types.

Why? I could boot whatever I want to repair any OS, an example:

- i could delete a mbr of any OS
- i could boot my favorite OS via above describe method to repair other OS mbr

The old change was too restrictive and it didn't take into account that it is multiboot format related.

Version-Release number of selected component (if applicable):
?

How reproducible:
100%

Steps to Reproduce:
1. have windows vm
2. try to use Run Once and specify linux/multiboot options for your kernel|initrd|append values of your taste
3. the VM should boot what you defined in linux/multiboot options

Actual results:
i can't boot for example kernel|ramdisk of a linux recovery distro to repair broken windows partitioning as I could not have linux/multiboot options available for non-Linux VMs

Expected results:
i should be able to use linux/multiboot options available for non-Linux VMs

Additional info:
discovered again after discussion about loading linux kernel/ramdisk from iso domain

Comment 1 Jiri Belka 2015-05-14 13:20:23 UTC
other OS that support multiboot format are netbsd and smartos (illumos).

Comment 2 Michal Skrivanek 2015-05-18 10:21:30 UTC
what's wrong with "Linux" ? You can use that with any pseudo-supported OSes

Comment 3 Jiri Belka 2015-05-18 10:56:38 UTC
I don't understand the question... So guessing. 'Linux' in this context is wrong as qemu-kvm --help itself uses 'Linux/Multiboot...'

# /usr/libexec/qemu-kvm --help | sed -n '/^Linux/,/^$/p'
Linux/Multiboot boot specific:
-kernel bzImage use 'bzImage' as kernel image
-append cmdline use 'cmdline' as kernel command line
-initrd file    use 'file' as initial ram disk
-dtb    file    use 'file' as device tree image

Google for multiboot format.

Comment 4 Jiri Belka 2015-05-18 14:02:04 UTC
Additional note:

- make it available in non-linux based VM
- change names to qemu-kvm style - thus 'kernel params' => append cmdline, as this could be something else:

See below, append/kernel_params state real kernel which would mboot.c32 use:

      KERNEL mboot.c32
      APPEND smartos/latest/platform/i86pc/kernel/amd64/unix -B smartos=true --- smartos/latest/platform/i86pc/amd64/boot_archive

Comment 5 Martin Tessun 2017-11-17 10:47:24 UTC
Hi Michal,

(In reply to Michal Skrivanek from comment #2)
> what's wrong with "Linux" ? You can use that with any pseudo-supported OSes

it is not about "linux", but about that submenu missing in RunOnce dialog in case you have defined a Windows OS for the VM.

If I understood the request correctly, we should enable the Linux Boot-Menu also for Windows (e.g. for booting some repair stuff, etc.) and therefore name it "Linux/Multiboot options".

Personally I don't believe anyone running Windows VMs will ever use this commandline, but instead boot from the network (via PXE) and repair the installation (or doing the repair differently).

Unless we have some real usecase for this, I would close wontfix.

Comment 6 Michal Skrivanek 2017-11-17 17:10:21 UTC
it is about that because that's what makes it shown in RunOnce. You can temporarily switch to "Linux" for any image really, it doesn't matter if it's windows or not.


Note You need to log in before you can comment on or make changes to this bug.