Red Hat Bugzilla – Bug 122538
Rebuilding dies at patches applying if SELinux is turned off
Last modified: 2007-11-30 17:10:42 EST
Description of problem:
Rebuilding dies at patches applying if SELinux is turned off:
--- snipp ---
Patch #1020 (util-linux-2.11z-03-krb5.patch):
+ patch -p1 -b --suffix .krb5 -s
+ echo 'Patch #1040 (util-linux-2.12-nfs-mount.patch):'
Patch #1040 (util-linux-2.12-nfs-mount.patch):
+ patch -p1 -b --suffix .nfsmount -s
+ echo 'Patch #1001 (util-linux-2.12-nfssloppy.patch):'
Patch #1001 (util-linux-2.12-nfssloppy.patch):
+ patch -p1 -b --suffix .nfssloppy -s
2 out of 5 hunks FAILED -- saving rejects to file mount/nfsmount.c.rej
error: Bad exit status from /var/tmp/rpm-tmp.6940 (%prep)
--- snapp ---
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Get util-linux-2.12-18 from Fedora Development
2. Turn SELinux off
3. Rebuild it
4. Get the error
There has to be a better patch merging, that the patch applying works
everytime. I think the SELinux patch should be the last patch, that
is applied to avoid problems like this.
Rebuilding should work with and without SELinux support.
Unfortunately, this type of change is not a high priority right now,
since SELinux is the future. You'll have to send a patch if you want
this to happen.
Why did I already know that before? ;-)
Okay, the following changes make it working for me for both:
Created attachment 100218 [details]
Created attachment 100219 [details]
Created attachment 100220 [details]
Created attachment 100221 [details]
As of util-linux-2.12a the SELinux patches are integrated into the
upstream sources, so turning off SELinux no longer makes sense for the
FC devel version.
Eek, and you did all that work too - I'm sorry! If there's still a
need to turn off selinux we can figure something out.
Reopening, because that closing reason was only a nice alibi,
Turning off or on SELinux makes also sense for util-linux-2.12a at
Fedora Core development.
I know, that non SELinux hasn't a high priority, so I did some patch
merging myself (as I already did it for 2.12) - working for me - and
attaching them here, again.
Maybe you can apply now these changes really and not defer them? That
would be very nice, thank you :-)
Created attachment 101439 [details]
Created attachment 101440 [details]
Created attachment 101441 [details]
Sorry, I don't see the point anymore. Turning off SELinux feature
compilation doesn't make sense for Fedora Core development especially
since SELinux is on by default, so I don't see that there's still a
need for turning SELinux off. We can talk about it on IRC if you like.