Bug 1226489 - [GTK3] set "system colors" off by default
Summary: [GTK3] set "system colors" off by default
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: firefox
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Stransky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-30 00:35 UTC by potato_farmer
Modified: 2018-06-04 10:45 UTC (History)
11 users (show)

Fixed In Version: firefox-38.0.5-2.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-11 18:35:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Sample web page displayed under Fedora 21 (87.73 KB, image/png)
2015-05-30 05:30 UTC, Joachim Frieben
no flags Details
Color preferences under Fedora 21 (85.18 KB, image/png)
2015-05-30 05:30 UTC, Joachim Frieben
no flags Details
Sample web page displayed under Fedora 22 (86.12 KB, image/png)
2015-05-30 05:31 UTC, Joachim Frieben
no flags Details
Color preferences under Fedora 22 (84.89 KB, image/png)
2015-05-30 05:32 UTC, Joachim Frieben
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Mozilla Foundation 1158076 0 None None None 2019-05-03 07:23:09 UTC

Description potato_farmer 2015-05-30 00:35:17 UTC
Description of problem:
Seems like Firefox is set to use "system colors" by default instead of browser colors. HTML pages that do not specify a background color appear gray instead of white. 

Version-Release number of selected component (if applicable):
Firefox 38.0.1

How reproducible:
Create any HTML page, do not specify a background color, view the page in Firefox. Or try about:blank

Expected results:
Default "white" background. 

Additional info:
It is possible that this is behavior by design and not a bug. Is this intentional?

Comment 1 Joachim Frieben 2015-05-30 05:30:04 UTC
Created attachment 1032360 [details]
Sample web page displayed under Fedora 21

Comment 2 Joachim Frieben 2015-05-30 05:30:41 UTC
Created attachment 1032361 [details]
Color preferences under Fedora 21

Comment 3 Joachim Frieben 2015-05-30 05:31:18 UTC
Created attachment 1032362 [details]
Sample web page displayed under Fedora 22

Comment 4 Joachim Frieben 2015-05-30 05:32:08 UTC
Created attachment 1032363 [details]
Color preferences under Fedora 22

Settings are exactly the same as under Fedora 21.

Comment 5 Martin Stransky 2015-05-30 06:19:49 UTC
Yes, I see. That's caused by Gtk3 build which uses widget background/text color as a base HTML colors. We need to fix that.

Comment 6 Joachim Frieben 2015-05-30 07:54:51 UTC
(In reply to potato_farmer from comment #0)
Uncheck "Use system colors" to recover previous behaviour.

Comment 7 April 2015-05-31 12:56:55 UTC
The specific issue here is that the background color (and text color) is coming from a different part of the user's system theme than it used to. It is now coming from the background and text colors for "Windows" instead of for "Input boxes" (these are the labels used in the Mate Desktop environment, anyway).

Firefox 38.0 in Fedora 20 and Fedora 21 uses the "Input boxes" colors for default background and text colors (most themes set these to black on white or white on black). Firefox 38.0 on Fedora 22 is instead using the colors for "Windows" (most themes set this to black on light gray or white on a shade of black). Since gtk3 is not officially supported by Mozilla, I presume the Fedora 20 behavior is their intention. It also makes more sense in my opinion, particularly given that the majority of themes specify black on white for Input boxes, which is what people expect by default on a web page.

Bug title should be adjusted to such as:
[GTK3] firefox in F22 uses different part of system colors for default webpage background and text

Comment 8 April 2015-05-31 13:31:21 UTC
bug 1226654 is a separate issue, but it could result in confusion while investigating this bug. If you need to test changes in system colors, you will need to do so by changing themes rather than adjusting the colors for the current theme.

Comment 9 Martin Stransky 2015-06-04 12:39:15 UTC
See https://bugzilla.mozilla.org/show_bug.cgi?id=1158076#c12 for details.

Comment 10 Martin Stransky 2015-06-05 13:07:43 UTC
You're right - the "system color" are selected by default. That's breaks websites in dark-theme at least and breaks also W3C HTML specification.

Comment 11 Martin Stransky 2015-06-05 13:17:05 UTC
Added to firefox-38.0.5-2.

Comment 12 Fedora Update System 2015-06-08 06:33:53 UTC
firefox-38.0.5-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/firefox-38.0.5-2.fc22

Comment 13 Fedora Update System 2015-06-09 15:01:21 UTC
Package firefox-38.0.5-2.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing firefox-38.0.5-2.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-9635/firefox-38.0.5-2.fc22
then log in and leave karma (feedback).

Comment 14 potato_farmer 2015-06-10 17:29:49 UTC
Installed firefox-38.0.5-2.fc22.

"dnf update --enablerepo=updates-testing firefox-38.0.5-2.fc22"

It no longer has use "System Colors" checked by default. 

Thanks for taking the time to fix this.

Comment 15 Devin Henderson 2015-06-11 00:17:12 UTC
This still doesn't fix the problem of form fields using the wrong colors. Is there an existing bug report for that issue? Are the form field colors related to the upstream bug re: about:config?

Thanks

Comment 16 Martin Stransky 2015-06-11 10:26:03 UTC
As a workaround you can try http://forums.fedoraforum.org/showpost.php?p=1703251&postcount=3

Comment 17 Fedora Update System 2015-06-11 18:35:53 UTC
firefox-38.0.5-2.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.