Bug 1229131 - etckeeper does not auto-commit after dnf installs/updates
Summary: etckeeper does not auto-commit after dnf installs/updates
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: etckeeper
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Thomas Moschny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-08 07:18 UTC by Tim Wegener
Modified: 2015-11-12 00:20 UTC (History)
3 users (show)

Fixed In Version: etckeeper-1.18.2-1.fc23 etckeeper-1.18.2-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-01 02:28:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tim Wegener 2015-06-08 07:18:01 UTC
Description of problem:

After doing a 'dnf update' or 'dnf install blahblah', where changes are made within /etc/, etckeeper does not auto-commit the changes. Running 'hg status /etc/' shows various uncommitted modifications.


Version-Release number of selected component (if applicable):

etckeeper-1.18.1-1.fc22.noarch


How reproducible:

Happens every time.


Steps to Reproduce:
1. dnf install <something that modifies /etc/ contents>
2. hg status /etc/


Actual results:

Uncommitted changes to /etc/ contents are present after dnf install.


Expected results:

etckeeper is meant to automatically commit any changes to /etc/ after packages are installed/updated.

Additional info:

Things were working fine in Fedora 20.

Comment 1 Joel Uckelman 2015-06-09 16:01:16 UTC
I ran into this problem using git as my VCS. I think what's needed is two things:

1) set "HIGHLEVEL_PACKAGE_MANAGER=dnf" in /etc/etckeeper/etckeeper.conf.
2) Install the etckeeper-dnf package.

#1 should really be changed in what the etckeeper package installs in F22, because F22 uses dnf.

Comment 2 Thomas Moschny 2015-06-09 16:16:23 UTC
(In reply to Tim Wegener from comment #0)
> After doing a 'dnf update' or 'dnf install blahblah', where changes are made
> within /etc/, etckeeper does not auto-commit the changes. Running 'hg status
> /etc/' shows various uncommitted modifications.

Do you have etckeeper-dnf installed?

(In reply to Joel Uckelman from comment #1)
> I ran into this problem using git as my VCS. I think what's needed is two
> things:
> 
> 1) set "HIGHLEVEL_PACKAGE_MANAGER=dnf" in /etc/etckeeper/etckeeper.conf.
> 2) Install the etckeeper-dnf package.
> 
> #1 should really be changed in what the etckeeper package installs in F22,
> because F22 uses dnf.

If I am not totally overlooking something, #2 is the relevant thing.
#1 is a purely cosmetic issue, as the HIGHLEVEL_PACKAGE_MANAGER variable is used only in informational strings.

Comment 3 Tim Wegener 2015-06-13 23:40:51 UTC
(In reply to Thomas Moschny from comment #2)
> (In reply to Tim Wegener from comment #0)
> > After doing a 'dnf update' or 'dnf install blahblah', where changes are made
> > within /etc/, etckeeper does not auto-commit the changes. Running 'hg status
> > /etc/' shows various uncommitted modifications.
> 
> Do you have etckeeper-dnf installed?


I did not have it installed.
After install it, it works.

So I guess the issue is that yum support worked out of the box with etckeeper in f20, so it seems like the same should be true for dnf in f22.

Comment 4 Alick Zhao 2015-10-16 04:14:41 UTC
Ran into the same issue.

I also think etckeeper-dnf should be pulled together by default since dnf is the default since F22. Why not?

Comment 5 Fedora Update System 2015-10-24 14:33:08 UTC
etckeeper-1.18.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1692f8e796

Comment 6 Fedora Update System 2015-10-24 14:33:08 UTC
etckeeper-1.18.2-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d270bfa661

Comment 7 Fedora Update System 2015-10-27 02:19:47 UTC
etckeeper-1.18.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update etckeeper'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1692f8e796

Comment 8 Fedora Update System 2015-10-28 20:26:49 UTC
etckeeper-1.18.2-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update etckeeper'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d270bfa661

Comment 9 Fedora Update System 2015-11-01 02:28:47 UTC
etckeeper-1.18.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2015-11-12 00:20:52 UTC
etckeeper-1.18.2-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.